Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dimension fields for transaction log datastream to enable TSDB. #5540

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Update dimension fields for transaction log datastream to enable TSDB. #5540

merged 8 commits into from
Mar 21, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 15, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

This PR adds dimension fields for transaction log datastream for mssql to enable TSDB.

Checklist

@ritalwar ritalwar marked this pull request as ready for review March 15, 2023 05:13
@ritalwar ritalwar requested a review from a team as a code owner March 15, 2023 05:13
@ritalwar ritalwar mentioned this pull request Mar 15, 2023
Closed
11 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T05:01:15.097+0000

  • Duration: 15 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) 👎 -6.667
Lines 100.0% (1238/1238) 💚 4.889
Conditionals 100.0% (0/0) 💚

agithomas
agithomas reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the comment the reason behind adding the dimension

agithomas
agithomas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 9357908 into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ritalwar @elasticmachine @agithomas