Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus] event.dataset is not correct if data_stream.dataset is set to not a default value #7654

Closed
tetianakravchenko opened this issue Sep 4, 2023 · 0 comments · Fixed by #7667
Closed

[prometheus] event.dataset is not correct if data_stream.dataset is set to not a default value #7654

tetianakravchenko opened this issue Sep 4, 2023 · 0 comments · Fixed by #7667
Assignees
@tetianakravchenko

Comments

@tetianakravchenko
Copy link
Contributor

  1. do we actually need to have event.dataset hardcoded?

event.dataset was explicitly set for prometheus - #1249
need to check original discussion

  1. data_stream.dataset setting does not affect the mapping for event.dataset, in the generated template was still set to prometheus.collector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetianakravchenko tetianakravchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[prometheus] Use ecs definition of the 'event.dataset' field tetianakravchenko/integrations
1 participant
@tetianakravchenko