Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fields that accept durations should describe the allowed units #6684

Closed
andrewkroh opened this issue Jun 23, 2023 · 2 comments · Fixed by #6992
Closed

Text fields that accept durations should describe the allowed units #6684

andrewkroh opened this issue Jun 23, 2023 · 2 comments · Fixed by #6992
Assignees

Comments

@andrewkroh
Copy link
Member

Any variables that expect a duration should specify the accepted time units. Let's add this string to descriptions on these variables.

Valid time units are "ns", "us", "ms", "s", "m", "h".

Here's an example where this is missing:

- name: initial_interval
type: text
title: Interval
multi: false
required: true
show_user: true
default: 120h
description: How far back to look for indicators the first time the agent is started.

(btw: An even better solution would be to have a duration input type in Kibana that ensured a proper duration was given.)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh changed the title Text fields at accept durations should describe the allowed units Text fields that accept durations should describe the allowed units Jun 23, 2023
@efd6 efd6 self-assigned this Jun 26, 2023
@andrewkroh
Copy link
Member Author

A duration type has been proposed in elastic/package-spec#44 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants