Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Redis Enterprise] Lens Migration #5674

Closed
6 tasks done
rajvi-patel-22 opened this issue Mar 24, 2023 · 16 comments
Closed
6 tasks done

[O11y][Redis Enterprise] Lens Migration #5674

rajvi-patel-22 opened this issue Mar 24, 2023 · 16 comments
Assignees

Comments

@rajvi-patel-22
Copy link
Contributor

rajvi-patel-22 commented Mar 24, 2023

Manually migrate Redis Enterprise visualizations to lens in current Kibana version 8.3.0 itself.

Preparation of data for testing

  • Use sample_event.json / setup live instance using docker / mock data using mock server to populate dashboards

Migration stats

Redis Enterprise dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metricbeat Redis Enterprise] Overview 0 12 11 0
  0 12 11 0

Note: One visualization is migrated to the new control panel.

Dashboard : [Metricbeat Redis Enterprise] Overview

Verification and Validation

  • Verification of functionality remains the same after migration in Kibana
  • Verification of data count of after-migrated visualization with before-migrated visualization in Kibana
  • Verification of Dashboard are not distorted in supported Kibana version (8.3.0)

Issues Identified

  • Gauge chart (arc) type is not available in lens. In Lens, only horizontal and vertical gauge chart are supported.
    [Lens] Support bullet/gauge chart kibana#89859
    Impact : [ Severity : Critical, Workaround : Yes (Convert the panel into either horizontal/vertical gauge chart or metric visualization)]
@rajvi-patel-22
Copy link
Contributor Author

As discussed with @SubhrataK, We will migrate gauge chart into horizontal/vertical gauge chart or metric type based on the below two scenario.

Scenario 1:
If the panel represents just the metric/count then it will be migrated to the metric visualization.

Before Migration:
image

After Migration:
image

Scenario 2:
If the panel represents the CPU Usage or Memory usage which can be represented as a part of whole then we will convert the panel to horizontal/vertical gauge chart.

Before migration:
image

After migration:
image (7)

@agithomas
Copy link
Contributor

As the workaround suggested is meeting the objective, no concerns in making the proposed changes.

@rajvi-patel-22
Copy link
Contributor Author

PR is approved and merged, hence closing this issue: #5678

@lalit-satapathy
Copy link
Collaborator

Running the latest Lens migrated version.

Before cluster name drop down:

Screenshot 2023-03-28 at 1 57 57 PM

After Lens Migration, cluster name drop down (version 0.4.0):

Screenshot 2023-03-28 at 2 03 11 PM

What is the extra "Exists" in the drop down? Is this an expected behaviour or some issue?

@lalit-satapathy
Copy link
Collaborator

In the Lens version is the info for each of the panel description now gone?

Before:

Screenshot 2023-03-28 at 2 39 50 PM

@rajvi-patel-22
Copy link
Contributor Author

In the Lens version is the info for each of the panel description now gone?

Yes @lalit-satapathy, By value lens panel doesn't show panel description. [GitHub issue]

@lalit-satapathy
Copy link
Collaborator

In the Lens version is the info for each of the panel description now gone?

Yes @lalit-satapathy, By value lens panel doesn't show panel description. [GitHub issue]

The description seems empty for now and I am able to add them by editing as below.
Screenshot 2023-03-28 at 3 00 41 PM

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Mar 28, 2023

What is the extra "Exists" in the drop down? Is this an expected behaviour or some issue?

@lalit-satapathy Yes! This is the new functionality added in new control panels. By default the option is enabled. However, we have an option to disable it.

Please find the below screenshot.
image

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Mar 28, 2023

The description seems empty for now and I am able to add them by editing as below. Screenshot 2023-03-28 at 3 00 41 PM

@lalit-satapathy, I don't see any option to add description in lens and Kibana issue is also open for the same. Can you please provide steps to add the description so that I can verify it from my end.

Can you also specify the Kibana version that you have?

@lalit-satapathy
Copy link
Collaborator

Can you also specify the Kibana version that you have?

It lets you update in 8.7.0-SNAPSHOT, May be its newly added.

@rajvi-patel-22
Copy link
Contributor Author

It lets you update in 8.7.0-SNAPSHOT, May be its newly added.

Yes @lalit-satapathy. It could be the case. Because I tried to add description in 8.3.0 and 8.6.1 but I didn't get the option.

@agithomas
Copy link
Contributor

@rajvi-elastic , as the PR is already merged, we have two options here considering the description is no longer available in the kibana dashboard

Option 1: Do a rollback
Option 2: Create a PR with say 8.7 as the version having the panel description.

The decision will soon be shared here. However, please work on the option 2 and share the issue & PR link here.

@agithomas
Copy link
Contributor

We also need to find out how much dashboards under various integration has description in panels.

a. Identify the json block in vis that holds the description info of the panels.

b. Grep the visualisation json of all integrations having the block.

c. Do the dashboard screenshot validation additionally.

We need to have the names of dashboards with integration impacted by the above mentioned problem. How many among in this list had a lens migration completed. Please take this up at the highest priority.

cc @lalit-satapathy , @harnish-elastic , @kush-elastic

@rajvi-patel-22
Copy link
Contributor Author

The decision will soon be shared here. However, please work on the option 2 and share the issue & PR link here.

@agithomas Please find the below Issue and PR for adding panel description in migrated lens visualizations.

Issue: #5723
PR Link: #5737

@rajvi-patel-22
Copy link
Contributor Author

We need to have the names of dashboards with integration impacted by the above mentioned problem. How many among in this list had a lens migration completed. Please take this up at the highest priority.

@agithomas, We have looked into the other integrations but no any other integrations are having the panel description apart from the Redis Enterprise.

@rajvi-patel-22
Copy link
Contributor Author

PR is approved and merged, hence closing this issue: #5737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants