Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Ensure compute metrics dashboard can be filtered by resource location #5020

Closed
endorama opened this issue Jan 17, 2023 · 5 comments
Closed
Assignees
Labels
enhancement New feature or request Integration:gcp Google Cloud Platform Stalled Team:Cloud-Monitoring Label for the Cloud Monitoring team

Comments

@endorama
Copy link
Member

#5006 highlighted that the GCP Compute dashboard has a missing visualisation. When it was present, it was a filtering widget that could be used to filter data by cloud.provider, cloud.account.id and gcp.billing.invoice_month.

The fix is in progress, this issue wants to track the addition of filtering by resource location to the dashboard controls.

@endorama endorama added enhancement New feature or request Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jan 17, 2023
@tommyers-elastic
Copy link
Contributor

@endorama resource location == cloud.region? or cloud.availability_zone ? what do you think?

@endorama
Copy link
Member Author

endorama commented Jan 18, 2023

That's interesting. In most dashboard we are using gcp.*.labels.resource.<location | region | zone>

The correct label depends on the service. I'm not sure we duplicate the data to cloud.* fields, but if that's the case for all we should still use either:

  • the one the service is using
  • both

What do you think?

Edit: we have a mapping services <> label here

@tommyers-elastic
Copy link
Contributor

interesting - the compute metrics don't have any labels.resource fields for me. but the aforementioned cloud. fields are populated here.

@tommyers-elastic tommyers-elastic changed the title Ensure GCP Compute dashboard can be filtered by resource location [GCP] Ensure compute metrics dashboard can be filtered by resource location Jan 19, 2023
@endorama
Copy link
Member Author

Could it be you are collecting metrics with exclude_labels: true? (docs)

exclude_labels: (true/false default false) Do not extract extra labels and metadata information from metricsets and fetch metrics only. At the moment, labels and metadata extraction is only supported in compute metricset.

@botelastic
Copy link

botelastic bot commented Jan 30, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 30, 2024
@botelastic botelastic bot closed this as completed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:gcp Google Cloud Platform Stalled Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

No branches or pull requests

2 participants