Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Enable synthetic source on new datasets by default #4287

Closed
ruflin opened this issue Sep 23, 2022 · 9 comments
Closed

[Discuss] Enable synthetic source on new datasets by default #4287

ruflin opened this issue Sep 23, 2022 · 9 comments
Labels

Comments

@ruflin
Copy link
Member

ruflin commented Sep 23, 2022

Synthetic source is now part of Elasticsearch and hopefully is soon GA: elastic/elasticsearch#86603 Especially for metrics data, synthetic sources brings a wide variety of advantages. In Fleet it will soon be possible to enable synthetic source per data stream to test it out.

To migrate to synthetic source quickly I'm proposing that all new metrics datasets we create synthetic source will be enabled by default.

In case we find alignment on the above proposal it would mean:

  • Update package dev docs with this recommendation
  • Inform teams about the approach

@jsoriano @gizas @tommyers-elastic @lalit-satapathy Please chime in.

@jsoriano
Copy link
Member

Depends on elastic/kibana#141211 (but integrations can already start using the source_mode flag).

@lalit-satapathy
Copy link
Collaborator

To migrate to synthetic source quickly I'm proposing that all new metrics datasets we create synthetic source will be enabled by default.

Sounds good for new datasets developed. I plan to close on the validation in couple of integrations to ensure no surprises in testing the integrations with the new mode.

@jsoriano, Will use the source_mode flag instead, for the testing if it is ready.

@ruflin
Copy link
Member Author

ruflin commented Nov 1, 2022

Making synthetic source a default is still blocked by elastic/kibana#141211 and making the synthetic source feature GA which is not the case as of the upcoming 8.5 AFAIK. As we have now an option to enable it, lets make sure we continue testing and as soon as we are unblocked on the Fleet side and synthetic source goes GA, we can start to adopt the feature more heavily.

@jsoriano What do you think about having a hint for newly created metric datasets in elastic-package tooling or similar to push devs to use this feature when it is ready? My concern is that otherwise it will not be fully adapted or by mistake not be used.

@jsoriano
Copy link
Member

jsoriano commented Nov 7, 2022

@jsoriano What do you think about having a hint for newly created metric datasets in elastic-package tooling or similar to push devs to use this feature when it is ready?

For new data streams created with elastic-package create, it would be an option to automatically set source_mode: synthetic in the manifest. This is something we could already do, and Kibana will leverage it once elastic/kibana#141211 is ready, with the option to toggle it off if from the UI it causes problems. I have created an issue for this: elastic/elastic-package#1026.

@P1llus
Copy link
Member

P1llus commented Jan 3, 2023

After discussion around this subject on Slack, the current situation in which synthetics is an option in the UI for ALL packages is unfortunately not going to work.

Any non-metrics package will by default not work with synthetics in its current state because we have event.original:
image
This field is included in all non-metrics packages.

Also, since synthetics is not supported on packages with flattened or wildcard mappings, which is pretty much all of them at some point, having this available by default is not really feasible.

I would suggest we put this behind a feature-flag for now, or make sure its only added to packages of type metrics.

@ruflin
Copy link
Member Author

ruflin commented Jan 4, 2023

The issue description state all new metrics datasets so I think the part forward here is still ok? @P1llus I can update the title to make it more clear, or do I miss something?

@P1llus
Copy link
Member

P1llus commented Jan 4, 2023

@ruflin the change was rolled out to all datasets at the moment, and after a discussion I was asked to post an update here :)

@ruflin
Copy link
Member Author

ruflin commented Jan 4, 2023

Lets make sure we don't confuse the UI toggle with the discussion here which is the default behaviour for metrics dataset which are unrelated feature.

Here is a follow up discussion around the UI toggle: elastic/kibana#148317

@botelastic
Copy link

botelastic bot commented Jan 4, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 4, 2024
@botelastic botelastic bot closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants