Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[7.x] [kibana] add service.httpPortName config in chart (#843) #959

Merged
merged 1 commit into from
Dec 1, 2020
Merged

[7.x] [kibana] add service.httpPortName config in chart (#843) #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kibana/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
nodePort: {{ .Values.service.nodePort }}
{{- end }}
protocol: TCP
name: http
name: {{ .Values.service.httpPortName | default "http" }}
targetPort: {{ .Values.httpPort }}
selector:
app: {{ .Chart.Name }}
Expand Down
13 changes: 13 additions & 0 deletions kibana/tests/kibana_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,3 +629,16 @@ def test_adding_loadBalancerIP():
r = helm_template(config)

assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79"


def test_service_port_name():
r = helm_template("")

config = """
service:
httpPortName: istio
"""

r = helm_template(config)

assert r["service"][name]["spec"]["ports"][0]["name"] == "istio"
1 change: 1 addition & 0 deletions kibana/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ service:
# service.beta.kubernetes.io/cce-load-balancer-internal-vpc: "true"
loadBalancerSourceRanges: []
# 0.0.0.0/0
httpPortName: http

ingress:
enabled: false
Expand Down