-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add integration tests and other tweaks for filebeat #121
Conversation
Without this it was only possible to have one filebeat daemonset per namespace. Probably an unlikely usecase but it does at least break our testing scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes make sense to me, agreed on all counts 👍
I think that having a "semi-opinionated" config out-of-the-box makes sense here since the alternative is basically a useless go process, it's probably worth a minor note in the filebeat chart's README so that people can get started quickly by setting the appropriate ELASTICSEARCH_HOSTS
extraEnv
and go. I can PR that later though.
Agreed! I think adding this to a Usage notes and getting started section like the Elasticsearch readme makes the most sense. Potentially giving an example of how to configure one of the other many filebeat ouputs could also be useful. But hopefully an example of how to configure filebeat.yml for Elasticsearch and add the right environment variable should be enough.
🙏 |
Apart from adding some integration tests and more templating tests I also made a few other changes: