Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go test fails on a clean windows install #14

Closed
eonarheim opened this issue Jan 20, 2016 · 3 comments
Closed

go test fails on a clean windows install #14

eonarheim opened this issue Jan 20, 2016 · 3 comments

Comments

@eonarheim
Copy link

Howdy!

I'm fairly new to go so help me out if I'm completely in left field on this one.

Running a plain go test on a clean windows install of gosigar fails. I believe that this is due to platform differences between windows and *nix systems that are not accounted for in the sigar_interface_test.go and the concrete_sigar_test.go outlined in detail in this pull request: /pull/13

One example is that executables in windows need a ".exe" suffix whereas in a *nix system this need not be the case

Apologies for the rough cmd window formatting :)

←[90mC:/Projects/GoWorkspace/src/github.com/elastic/gosigar/sigar_interface_
test.go:100←[0m

  ←[91mExpected
      <[]string | len:2, cap:2>: ["go", "ginkgo"]
  to contain element matching
      <string>: go.exe←[0m

Perhaps an appveyor + travis CI server would help illuminate these types of issues by building and running tests on all environments gosigar is deployed :)

@ruflin
Copy link

ruflin commented Jan 21, 2016

There is already a travis build running: https://travis-ci.org/elastic/gosigar It would be great if we could also add appveyor for the windows build.

Probably we should also link the Travis build in the README: https://github.com/elastic/gosigar/blob/master/README.md

For the appveyor config it is best to have a look at the file from the beats project: https://github.com/elastic/beats/blob/master/.appveyor.yml

@andrewkroh
Copy link
Member

go test is passing on Windows.

AppVeyor and TravisCI both build this project (and badges added to README).

@eonarheim
Copy link
Author

Awesome! 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants