Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update elastic/beats in go.mod once v8.0.0 has been released #971

Closed
michel-laterman opened this issue Dec 8, 2021 · 3 comments
Closed
Labels
cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@michel-laterman
Copy link
Contributor

PR #970 updated the go.mod file to an untagged commit on the 8.0 branch to allow fleet-server to use up to date code from libbeat (specifically new ca fingerprint handling).

Once v8.0.0 has been released and tagged we should set our go.mod to refer to this version.

@michel-laterman
Copy link
Contributor Author

Currently the go.mod of the beats repo is set to have the v7 major version. go detects incompatible major versions when trying to update to v8.x. We will not be able to use a tagged version of the beats module unless the module is updated to point provide v8 paths.

An alternative solution is to change the beats import to use https://github.com/elastic/elastic-agent-libs

@ph
Copy link
Contributor

ph commented Apr 12, 2022

Yes, the data plane have looked at moving to v8, but that decided the number of changes didn't worth the risk. So we will run off a commit for a long time.

@ph
Copy link
Contributor

ph commented Apr 12, 2022

See this elastic/beats#31213 (comment) I will close this issue.

@ph ph closed this as completed Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

2 participants