From a8c72c8a397da7ca7805a33eb96ea19db8dd880d Mon Sep 17 00:00:00 2001
From: Chandler Prall <chandler.prall@gmail.com>
Date: Tue, 15 May 2018 14:03:03 -0600
Subject: [PATCH 1/2] pass extra props from EuiInMemoryTable to EuiBasicTable

---
 .../__snapshots__/basic_table.test.js.snap    | 32 +++++++
 .../in_memory_table.test.js.snap              | 88 +++++++++++++++++++
 src/components/basic_table/basic_table.js     | 27 +++++-
 src/components/basic_table/in_memory_table.js |  2 +
 4 files changed, 147 insertions(+), 2 deletions(-)

diff --git a/src/components/basic_table/__snapshots__/basic_table.test.js.snap b/src/components/basic_table/__snapshots__/basic_table.test.js.snap
index b54c262d81f..052faed5f43 100644
--- a/src/components/basic_table/__snapshots__/basic_table.test.js.snap
+++ b/src/components/basic_table/__snapshots__/basic_table.test.js.snap
@@ -2,7 +2,9 @@
 
 exports[`EuiBasicTable basic - empty - custom message 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -37,7 +39,9 @@ exports[`EuiBasicTable basic - empty - custom message 1`] = `
 
 exports[`EuiBasicTable basic - empty - custom message as node 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -80,7 +84,9 @@ exports[`EuiBasicTable basic - empty - custom message as node 1`] = `
 
 exports[`EuiBasicTable basic - empty 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -115,7 +121,9 @@ exports[`EuiBasicTable basic - empty 1`] = `
 
 exports[`EuiBasicTable basic - with items 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -276,7 +284,9 @@ exports[`EuiBasicTable itemIdToExpandedRowMap renders an expanded row 1`] = `
 
 exports[`EuiBasicTable with pagination - 2nd page 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -344,7 +354,9 @@ exports[`EuiBasicTable with pagination - 2nd page 1`] = `
 
 exports[`EuiBasicTable with pagination 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -428,7 +440,9 @@ exports[`EuiBasicTable with pagination 1`] = `
 
 exports[`EuiBasicTable with pagination and error 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -469,7 +483,9 @@ exports[`EuiBasicTable with pagination and error 1`] = `
 
 exports[`EuiBasicTable with pagination and selection 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -611,7 +627,9 @@ exports[`EuiBasicTable with pagination and selection 1`] = `
 
 exports[`EuiBasicTable with pagination, selection and sorting 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
@@ -770,7 +788,9 @@ exports[`EuiBasicTable with pagination, selection and sorting 1`] = `
 
 exports[`EuiBasicTable with pagination, selection, sorting and a single record action 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
@@ -1020,7 +1040,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and a single record a
 
 exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
@@ -1179,7 +1201,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1
 
 exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
@@ -1338,7 +1362,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1
 
 exports[`EuiBasicTable with pagination, selection, sorting and multiple record actions 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
@@ -1582,7 +1608,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and multiple record a
 
 exports[`EuiBasicTable with pagination, selection, sorting, column renderer and column dataType 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
@@ -1741,7 +1769,9 @@ exports[`EuiBasicTable with pagination, selection, sorting, column renderer and
 
 exports[`EuiBasicTable with sortable columns and sorting disabled 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile />
@@ -1814,7 +1844,9 @@ exports[`EuiBasicTable with sortable columns and sorting disabled 1`] = `
 
 exports[`EuiBasicTable with sorting 1`] = `
 <div
+  aria-label="aria-label"
   className="euiBasicTable testClass1 testClass2"
+  data-test-subj="test subject string"
 >
   <div>
     <EuiTableHeaderMobile>
diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap
index e628f608a7b..9521fd17c07 100644
--- a/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap
+++ b/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap
@@ -2,6 +2,8 @@
 
 exports[`EuiInMemoryTable empty array 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -11,6 +13,7 @@ exports[`EuiInMemoryTable empty array 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={Array []}
   noItemsMessage="No items found"
@@ -21,6 +24,8 @@ exports[`EuiInMemoryTable empty array 1`] = `
 
 exports[`EuiInMemoryTable with initial sorting 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -31,6 +36,7 @@ exports[`EuiInMemoryTable with initial sorting 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -64,6 +70,8 @@ exports[`EuiInMemoryTable with initial sorting 1`] = `
 
 exports[`EuiInMemoryTable with items 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -73,6 +81,7 @@ exports[`EuiInMemoryTable with items 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -98,6 +107,8 @@ exports[`EuiInMemoryTable with items 1`] = `
 
 exports[`EuiInMemoryTable with items and expanded item 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -107,6 +118,7 @@ exports[`EuiInMemoryTable with items and expanded item 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={
     Object {
       "1": <div>
@@ -138,6 +150,8 @@ exports[`EuiInMemoryTable with items and expanded item 1`] = `
 
 exports[`EuiInMemoryTable with items and message - expecting to show the items 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -147,6 +161,7 @@ exports[`EuiInMemoryTable with items and message - expecting to show the items 1
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -172,6 +187,8 @@ exports[`EuiInMemoryTable with items and message - expecting to show the items 1
 
 exports[`EuiInMemoryTable with message 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -181,6 +198,7 @@ exports[`EuiInMemoryTable with message 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={Array []}
   noItemsMessage="where my items at?"
@@ -191,6 +209,8 @@ exports[`EuiInMemoryTable with message 1`] = `
 
 exports[`EuiInMemoryTable with message and loading 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -200,6 +220,7 @@ exports[`EuiInMemoryTable with message and loading 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={Array []}
   loading={true}
@@ -211,6 +232,8 @@ exports[`EuiInMemoryTable with message and loading 1`] = `
 
 exports[`EuiInMemoryTable with pagination 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -220,6 +243,7 @@ exports[`EuiInMemoryTable with pagination 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -231,6 +255,10 @@ exports[`EuiInMemoryTable with pagination 1`] = `
         "id": "2",
         "name": "name2",
       },
+      Object {
+        "id": "3",
+        "name": "name3",
+      },
     ]
   }
   noItemsMessage="No items found"
@@ -253,6 +281,8 @@ exports[`EuiInMemoryTable with pagination 1`] = `
 
 exports[`EuiInMemoryTable with pagination and default page size 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -262,6 +292,7 @@ exports[`EuiInMemoryTable with pagination and default page size 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -299,6 +330,8 @@ exports[`EuiInMemoryTable with pagination and default page size 1`] = `
 
 exports[`EuiInMemoryTable with pagination and selection 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -308,6 +341,7 @@ exports[`EuiInMemoryTable with pagination and selection 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -351,6 +385,8 @@ exports[`EuiInMemoryTable with pagination and selection 1`] = `
 
 exports[`EuiInMemoryTable with pagination, default page size and error 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -360,6 +396,7 @@ exports[`EuiInMemoryTable with pagination, default page size and error 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   error="ouch!"
   itemIdToExpandedRowMap={Object {}}
   items={
@@ -390,6 +427,8 @@ exports[`EuiInMemoryTable with pagination, default page size and error 1`] = `
 
 exports[`EuiInMemoryTable with pagination, selection and sorting 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -400,6 +439,7 @@ exports[`EuiInMemoryTable with pagination, selection and sorting 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -455,6 +495,8 @@ exports[`EuiInMemoryTable with pagination, selection, sorting  and simple search
     size="l"
   />
   <EuiBasicTable
+    aria-label="aria-label"
+    className="testClass1 testClass2"
     columns={
       Array [
         Object {
@@ -476,6 +518,7 @@ exports[`EuiInMemoryTable with pagination, selection, sorting  and simple search
         },
       ]
     }
+    data-test-subj="test subject string"
     itemIdToExpandedRowMap={Object {}}
     items={
       Array [
@@ -508,6 +551,7 @@ exports[`EuiInMemoryTable with pagination, selection, sorting  and simple search
       }
     }
     responsive={true}
+    search={true}
     selection={
       Object {
         "itemId": "id",
@@ -525,6 +569,8 @@ exports[`EuiInMemoryTable with pagination, selection, sorting  and simple search
 
 exports[`EuiInMemoryTable with pagination, selection, sorting and a single record action 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -546,6 +592,7 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and a single recor
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -594,6 +641,8 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and a single recor
 
 exports[`EuiInMemoryTable with pagination, selection, sorting and column renderer 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -605,6 +654,7 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and column rendere
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
@@ -616,6 +666,10 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and column rendere
         "id": "2",
         "name": "name2",
       },
+      Object {
+        "id": "3",
+        "name": "name3",
+      },
     ]
   }
   noItemsMessage="No items found"
@@ -676,6 +730,8 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and configured sea
     size="l"
   />
   <EuiBasicTable
+    aria-label="aria-label"
+    className="testClass1 testClass2"
     columns={
       Array [
         Object {
@@ -697,6 +753,7 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and configured sea
         },
       ]
     }
+    data-test-subj="test subject string"
     itemIdToExpandedRowMap={Object {}}
     items={
       Array [
@@ -704,6 +761,14 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and configured sea
           "id": "1",
           "name": "name1",
         },
+        Object {
+          "id": "2",
+          "name": "name2",
+        },
+        Object {
+          "id": "3",
+          "name": "name3",
+        },
       ]
     }
     noItemsMessage="No items found"
@@ -721,6 +786,26 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and configured sea
       }
     }
     responsive={true}
+    search={
+      Object {
+        "box": Object {
+          "aria-label": "aria-label",
+          "className": "testClass1 testClass2",
+          "data-test-subj": "test subject string",
+          "incremental": true,
+        },
+        "defaultQuery": "name:name1",
+        "filters": Array [
+          Object {
+            "field": "name",
+            "name": "Name1",
+            "negatedName": "Not Name1",
+            "type": "field_value_toggle",
+            "value": "name1",
+          },
+        ],
+      }
+    }
     selection={
       Object {
         "itemId": "id",
@@ -738,6 +823,8 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and configured sea
 
 exports[`EuiInMemoryTable with sorting 1`] = `
 <EuiBasicTable
+  aria-label="aria-label"
+  className="testClass1 testClass2"
   columns={
     Array [
       Object {
@@ -748,6 +835,7 @@ exports[`EuiInMemoryTable with sorting 1`] = `
       },
     ]
   }
+  data-test-subj="test subject string"
   itemIdToExpandedRowMap={Object {}}
   items={
     Array [
diff --git a/src/components/basic_table/basic_table.js b/src/components/basic_table/basic_table.js
index 1582bf3ee08..82ecdcfc96d 100644
--- a/src/components/basic_table/basic_table.js
+++ b/src/components/basic_table/basic_table.js
@@ -139,6 +139,11 @@ const BasicTablePropTypes = {
   noItemsMessage: PropTypes.node,
   className: PropTypes.string,
   compressed: PropTypes.bool,
+  itemIdToExpandedRowMap: PropTypes.object,
+  responsive: PropTypes.bool,
+  isSelectable: PropTypes.bool,
+  isExpandable: PropTypes.bool,
+  hasActions: PropTypes.bool
 };
 
 export class EuiBasicTable extends Component {
@@ -267,7 +272,25 @@ export class EuiBasicTable extends Component {
   }
 
   render() {
-    const { className, loading } = this.props;
+    const {
+      className,
+      loading,
+      items, // eslint-disable-line no-unused-vars
+      columns, // eslint-disable-line no-unused-vars
+      pagination, // eslint-disable-line no-unused-vars
+      sorting, // eslint-disable-line no-unused-vars
+      selection, // eslint-disable-line no-unused-vars
+      onChange, // eslint-disable-line no-unused-vars
+      error, // eslint-disable-line no-unused-vars
+      noItemsMessage, // eslint-disable-line no-unused-vars
+      compressed, // eslint-disable-line no-unused-vars
+      itemIdToExpandedRowMap, // eslint-disable-line no-unused-vars
+      responsive, // eslint-disable-line no-unused-vars
+      isSelectable, // eslint-disable-line no-unused-vars
+      isExpandable, // eslint-disable-line no-unused-vars
+      hasActions, // eslint-disable-line no-unused-vars
+      ...rest
+    } = this.props;
 
     const classes = classNames(
       'euiBasicTable',
@@ -281,7 +304,7 @@ export class EuiBasicTable extends Component {
     const paginationBar = this.renderPaginationBar();
 
     return (
-      <div className={classes}>
+      <div className={classes} {...rest}>
         {table}
         {paginationBar}
       </div>
diff --git a/src/components/basic_table/in_memory_table.js b/src/components/basic_table/in_memory_table.js
index d06bf0f05da..b5a39f8578e 100644
--- a/src/components/basic_table/in_memory_table.js
+++ b/src/components/basic_table/in_memory_table.js
@@ -260,6 +260,7 @@ export class EuiInMemoryTable extends Component {
       pagination: hasPagination,
       sorting: hasSorting,
       itemIdToExpandedRowMap,
+      ...rest
     } = this.props;
 
     const {
@@ -307,6 +308,7 @@ export class EuiInMemoryTable extends Component {
         noItemsMessage={message}
         compressed={compressed}
         itemIdToExpandedRowMap={itemIdToExpandedRowMap}
+        {...rest}
       />
     );
 

From 8130a1dd29d494509fd4cb6fe4a95b37e0ecd388 Mon Sep 17 00:00:00 2001
From: Chandler Prall <chandler.prall@gmail.com>
Date: Thu, 17 May 2018 13:14:42 -0600
Subject: [PATCH 2/2] changelog

---
 CHANGELOG.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5156fd31ab9..c9d7a103532 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
+**Bug fixes**
+- `EuiInMemoryTable` and `EuiBasicTable` now pass unknown props through to their child ([#836](https://github.com/elastic/eui/pull/836)) 
+
 **Breaking changes**
 
 - Move `EuiBasicTable`'s `itemId` prop from `selection` to a top-level property ([#830](https://github.com/elastic/eui/pull/830))