[EuiProgress docs] Removing callout and other fixes #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabetdev
added
the
documentation
cee-chen
approved these changes
Jun 23, 2022
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks great!! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5994/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a follow-up on #5986:
Removed the following callout that is no longer valid:
Added info about the
valueTextwhich renders with a high contrast version of the colorAlso fixed a link that was pointing to an old page.
Checklist
Checked in both light and dark modesChecked in mobileChecked in Chrome, Safari, Edge, and FirefoxProps have proper autodocs and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modesUpdated the Figma library counterpartA changelog entry exists and is marked appropriately