diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d40d567e3c..5674038c24b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ # [`master`](https://github.com/elastic/eui/tree/master) +- Minor style-only changes to `EuiPagination`, button reset, `EuiTableHeaderCell`, and `EuiCodeBlock` [(#298)](https://github.com/elastic/eui/pull/298) - All NPM dependencies now use ^ to install the latest minor version. - Added Apache, Nginx, MySQL logos [(#270)](https://github.com/elastic/eui/pull/270) - Added small version of `EuiCallOut` [(#269)](https://github.com/elastic/eui/pull/269) diff --git a/src/components/code/_code_block.scss b/src/components/code/_code_block.scss index 16369874ac6..4b2ad86eb42 100644 --- a/src/components/code/_code_block.scss +++ b/src/components/code/_code_block.scss @@ -71,11 +71,11 @@ ** 1. Size the code against the text its embedded within. **/ &.euiCodeBlock--inline { - vertical-align: middle; display: inline-block; white-space: pre; color: $euiTextColor; - font-size: 75%; // 1 + font-size: 90%; // 1 + padding: 0 $euiSizeS; background: $euiColorLightestShade; .euiCodeBlock__pre { diff --git a/src/components/form/switch/switch.js b/src/components/form/switch/switch.js index f6df648d162..3b5046aaab2 100644 --- a/src/components/form/switch/switch.js +++ b/src/components/form/switch/switch.js @@ -63,7 +63,3 @@ EuiSwitch.propTypes = { checked: PropTypes.bool, onChange: PropTypes.func, }; - -EuiSwitch.defaultProps = { - defaultChecked: false, -}; diff --git a/src/components/link/_mixins.scss b/src/components/link/_mixins.scss index a23318a54a6..86de1a0c5b4 100644 --- a/src/components/link/_mixins.scss +++ b/src/components/link/_mixins.scss @@ -1,4 +1,6 @@ @mixin euiLink { + text-align: left; + &:hover { text-decoration: underline; } diff --git a/src/components/pagination/pagination.js b/src/components/pagination/pagination.js index e0a940cba1f..41ccaf9203f 100644 --- a/src/components/pagination/pagination.js +++ b/src/components/pagination/pagination.js @@ -108,6 +108,11 @@ export const EuiPagination = ({ ); } + let selectablePages; + if (pages.length > 1) { + selectablePages = pages; + } + return (
{previousButton} {firstPageButtons} - {pages} + {selectablePages} {lastPageButtons} {nextButton}
diff --git a/src/components/table/_table.scss b/src/components/table/_table.scss index 97c2209b62b..7975be9c18e 100644 --- a/src/components/table/_table.scss +++ b/src/components/table/_table.scss @@ -56,7 +56,6 @@ .euiTableSortIcon { margin-left: $euiSizeXS; - fill: tintOrShade($euiTitleColor, 80%, 70%); .euiTableHeaderButton-isSorted & { fill: $euiTitleColor; diff --git a/src/components/table/table_header_cell.js b/src/components/table/table_header_cell.js index ff7f73c4362..1f4c5416902 100644 --- a/src/components/table/table_header_cell.js +++ b/src/components/table/table_header_cell.js @@ -34,13 +34,16 @@ export const EuiTableHeaderCell = ({ }); if (onSort) { - const sortIcon = ( - - ); + let sortIcon; + if (isSorted) { + sortIcon = ( + + ); + } const buttonClasses = classNames('euiTableHeaderButton', { 'euiTableHeaderButton-isSorted': isSorted,