From f65f873fd715355c4217c049d55632c76ca7cb6a Mon Sep 17 00:00:00 2001 From: Soham Kar Date: Tue, 24 Sep 2019 11:41:40 +0530 Subject: [PATCH 1/3] Update popover.tsx Popover fall back slices an undefined value #2362 --- src/components/popover/popover.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/popover/popover.tsx b/src/components/popover/popover.tsx index 2f41b58be03..d3b9cc38270 100644 --- a/src/components/popover/popover.tsx +++ b/src/components/popover/popover.tsx @@ -358,7 +358,7 @@ export class EuiPopover extends Component { // for each child element of `this.panel`, find any transition duration we should wait for before stabilizing const { durationMatch, delayMatch } = Array.prototype.slice - .call(this.panel ? this.panel.children : undefined) + .call(this.panel ? this.panel.children : []) .reduce( ({ durationMatch, delayMatch }, element) => { const transitionTimings = getTransitionTimings(element); From cdc376e6d166aab1afad881a11fcb1d21e64979f Mon Sep 17 00:00:00 2001 From: Soham Kar Date: Tue, 24 Sep 2019 20:46:45 +0530 Subject: [PATCH 2/3] Update CHANGELOG.md Fix for issue #2362 --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d3569c5ea32..5bd296b17c0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ **Bug fixes** - Fixed spacing of `EuiFormErrorText` to match `EuiFormHelpText` ([#2354](https://github.com/elastic/eui/pull/2354)) +- Fixed bug where Array.prototype.slice() may have been called on 'undefined' ([]()) ## [`14.2.0`](https://github.com/elastic/eui/tree/v14.2.0) From 5d778c5992e5c2f94dd4218f7851a12d07e806f7 Mon Sep 17 00:00:00 2001 From: Soham Kar Date: Tue, 24 Sep 2019 21:39:37 +0530 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5bd296b17c0..ab181540233 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ **Bug fixes** - Fixed spacing of `EuiFormErrorText` to match `EuiFormHelpText` ([#2354](https://github.com/elastic/eui/pull/2354)) -- Fixed bug where Array.prototype.slice() may have been called on 'undefined' ([]()) +- Fixed bug in `EuiPopover` where Array.prototype.slice() may have been called on 'undefined' ([#2369](https://github.com/elastic/eui/pull/2369)) ## [`14.2.0`](https://github.com/elastic/eui/tree/v14.2.0)