From 302d21cd0c378590ce8f7f9af91426f3a85e19bb Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Mon, 23 Sep 2019 16:27:48 -0400 Subject: [PATCH 1/6] use for EuiFacetButton :focus --- src/components/facet/_facet_button.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/facet/_facet_button.scss b/src/components/facet/_facet_button.scss index 886d6f26d00..12cce9ea348 100644 --- a/src/components/facet/_facet_button.scss +++ b/src/components/facet/_facet_button.scss @@ -25,7 +25,7 @@ } &:focus { - background-color: $euiColorLightestShade; + background-color: $euiFocusBackgroundColor; } &:disabled { From b4b8c58cee5d117a95596f8559d08a9d7ea4a44e Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Tue, 24 Sep 2019 16:39:04 -0400 Subject: [PATCH 2/6] Updated changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d3569c5ea32..cfa4a105520 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Modified `EuiFacetButton` to use `$euiFocusBackgroundColor` for `:focus` state ([2365](https://github.com/elastic/eui/pull/2365)) + **Bug fixes** - Fixed spacing of `EuiFormErrorText` to match `EuiFormHelpText` ([#2354](https://github.com/elastic/eui/pull/2354)) From 777592d4b539819379569d7e78e39dffc896c60c Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Tue, 24 Sep 2019 16:40:39 -0400 Subject: [PATCH 3/6] removed trailing whitespace --- src/components/facet/_facet_button.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/facet/_facet_button.scss b/src/components/facet/_facet_button.scss index 12cce9ea348..9ae3b5f616b 100644 --- a/src/components/facet/_facet_button.scss +++ b/src/components/facet/_facet_button.scss @@ -10,6 +10,7 @@ @include euiFontSizeS; text-align: left; border: none; + padding: inherit 4px; transform: none !important; /* 1 */ animation: none !important; /* 1 */ transition: all $euiAnimSpeedFast ease-in; /* 2 */ From d56719323e727c4d3dbf74c505e4eda025b543c6 Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Tue, 24 Sep 2019 17:52:52 -0400 Subject: [PATCH 4/6] fixed indentation --- src/components/facet/_facet_button.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/components/facet/_facet_button.scss b/src/components/facet/_facet_button.scss index 9ae3b5f616b..ba37471ea65 100644 --- a/src/components/facet/_facet_button.scss +++ b/src/components/facet/_facet_button.scss @@ -27,6 +27,8 @@ &:focus { background-color: $euiFocusBackgroundColor; + // use box-shadow as a "faux outline" to apply left/right padding only + box-shadow: -4px 0 $euiFocusBackgroundColor, 4px 0 $euiFocusBackgroundColor; } &:disabled { From 4c3ba96acb6a1f6d73cd4e61edd219f3aa5d80a6 Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Tue, 24 Sep 2019 17:56:38 -0400 Subject: [PATCH 5/6] fixed my mistake / leftover code --- src/components/facet/_facet_button.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/facet/_facet_button.scss b/src/components/facet/_facet_button.scss index ba37471ea65..323df7ea191 100644 --- a/src/components/facet/_facet_button.scss +++ b/src/components/facet/_facet_button.scss @@ -10,7 +10,6 @@ @include euiFontSizeS; text-align: left; border: none; - padding: inherit 4px; transform: none !important; /* 1 */ animation: none !important; /* 1 */ transition: all $euiAnimSpeedFast ease-in; /* 2 */ From e29bec82bae36a96dc5146ebaf63db95ac8b5f4a Mon Sep 17 00:00:00 2001 From: Henry Harding Date: Tue, 24 Sep 2019 18:08:02 -0400 Subject: [PATCH 6/6] use euiSizeXS instead of px value --- src/components/facet/_facet_button.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/facet/_facet_button.scss b/src/components/facet/_facet_button.scss index 323df7ea191..8a2e1de4611 100644 --- a/src/components/facet/_facet_button.scss +++ b/src/components/facet/_facet_button.scss @@ -27,7 +27,7 @@ &:focus { background-color: $euiFocusBackgroundColor; // use box-shadow as a "faux outline" to apply left/right padding only - box-shadow: -4px 0 $euiFocusBackgroundColor, 4px 0 $euiFocusBackgroundColor; + box-shadow: -$euiSizeXS 0 $euiFocusBackgroundColor, $euiSizeXS 0 $euiFocusBackgroundColor; } &:disabled {