From 8a93d8b075cc9d50f9668216a19debadf39259e8 Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Mon, 10 Dec 2018 16:24:49 -0800 Subject: [PATCH 1/3] revert combobox onblur creation --- CHANGELOG.md | 3 ++- src/components/combo_box/combo_box.js | 6 ------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 78fbdba2afb..e718a018ff2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ **Bug fixes** - `react-datepicker` set milliseconds to zero when selecting time ([#1361](https://github.com/elastic/eui/pull/1361)) +- Revert ([#1353](https://github.com/elastic/eui/pull/1353)) `onBlur` action on `euiComboBox`. It caused regressions on Kibana. ([#1361](https://github.com/elastic/eui/pull/1361)) ## [`5.5.1`](https://github.com/elastic/eui/tree/v5.5.1) @@ -15,7 +16,7 @@ ## [`5.5.0`](https://github.com/elastic/eui/tree/v5.5.0) -**Note: this release broke the exported TypeScript definitions. This is fixed in `5.5.1`.** +**Note: this release broke the exported TypeScript definitions and `EuiComboBox` in certain situations. These are both fixed in `5.5.3`.** - Altered functionality of `truncate` on `EuiBreadcrumbs` and added `truncate` ability on breadcrumb item ([#1346](https://github.com/elastic/eui/pull/1346)) - Altered `EuiHeader`'s location of `EuiHeaderBreadcrumbs` based on the new `truncate` ability ([#1346](https://github.com/elastic/eui/pull/1346)) diff --git a/src/components/combo_box/combo_box.js b/src/components/combo_box/combo_box.js index 38442993128..c81d2f3170b 100644 --- a/src/components/combo_box/combo_box.js +++ b/src/components/combo_box/combo_box.js @@ -258,12 +258,6 @@ export class EuiComboBox extends Component { this.closeList(); } - // If the user tabs away or changes focus to another element, take whatever input they've - // typed and convert it into a pill, to prevent the combo box from looking like a text input. - if (!this.hasActiveOption()) { - this.addCustomOption(); - } - if (this.props.onBlur) { this.props.onBlur(e); } From 5619357349e25d1d93eefae53d4b8d09ca64c761 Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Mon, 10 Dec 2018 16:33:52 -0800 Subject: [PATCH 2/3] correct pr link --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e718a018ff2..032ce37b30e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ **Bug fixes** - `react-datepicker` set milliseconds to zero when selecting time ([#1361](https://github.com/elastic/eui/pull/1361)) -- Revert ([#1353](https://github.com/elastic/eui/pull/1353)) `onBlur` action on `euiComboBox`. It caused regressions on Kibana. ([#1361](https://github.com/elastic/eui/pull/1361)) +- Revert ([#1353](https://github.com/elastic/eui/pull/1353)) `onBlur` action on `euiComboBox`. It caused regressions on Kibana. ([#1363](https://github.com/elastic/eui/pull/1363)) ## [`5.5.1`](https://github.com/elastic/eui/tree/v5.5.1) From b9c59a1d2e882d4b93b34251a41bc5b6760b7b3f Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Mon, 10 Dec 2018 16:38:56 -0800 Subject: [PATCH 3/3] fix cl ref --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 032ce37b30e..969276f05f8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ ## [`5.5.0`](https://github.com/elastic/eui/tree/v5.5.0) -**Note: this release broke the exported TypeScript definitions and `EuiComboBox` in certain situations. These are both fixed in `5.5.3`.** +**Note: this release broke the exported TypeScript definitions and `EuiComboBox` in certain situations. These are both fixed in `5.5.2`.** - Altered functionality of `truncate` on `EuiBreadcrumbs` and added `truncate` ability on breadcrumb item ([#1346](https://github.com/elastic/eui/pull/1346)) - Altered `EuiHeader`'s location of `EuiHeaderBreadcrumbs` based on the new `truncate` ability ([#1346](https://github.com/elastic/eui/pull/1346))