From 693774c266df9baf220c7df4be0db691206d89b1 Mon Sep 17 00:00:00 2001 From: Chandler Prall Date: Wed, 21 Nov 2018 15:41:54 -0700 Subject: [PATCH 1/2] 1324: copy ExpressionButton's active state to a focused state --- src/components/expression/_expression.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/expression/_expression.scss b/src/components/expression/_expression.scss index c44ebeb38c5..1799fa1b56c 100644 --- a/src/components/expression/_expression.scss +++ b/src/components/expression/_expression.scss @@ -10,6 +10,10 @@ border-bottom: $euiBorderEditable; font-size: $euiFontSize; cursor: pointer; + + &:focus { + border-bottom: solid 2px $expressionColorHighlight; + } } .euiExpressionButton__description { From 8467960371c384892ac45b383259b0ce176afb14 Mon Sep 17 00:00:00 2001 From: Chandler Prall Date: Wed, 21 Nov 2018 15:51:51 -0700 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f1c80d5bac2..6a6517dd728 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - `EuiBasicTable` now converts the `EuiTableRowCell` `header` into `undefined` if it's been provided as a non-string node, hiding the header and preventing the node from being rendered as `[object Object]` on narrow screens ([#1312](https://github.com/elastic/eui/pull/1312)) - Fixed `fullWidth` size of `EuiComboBox`, a regression introduced in `4.7.0` ([#1314](https://github.com/elastic/eui/pull/1314)) - Fixed error when passing empty string as `value` prop for `EuiSuperSelect` ([#1319](https://github.com/elastic/eui/pull/1319)) +- `EuiExpressionButton` now shows focus state when user tabs to it ([#1326](https://github.com/elastic/eui/pull/1326)) ## [`5.1.0`](https://github.com/elastic/eui/tree/v5.1.0)