From 11da7ee2e210d8b0541048dcfb834ca189bbba3b Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Tue, 31 Jul 2018 16:44:22 -0700 Subject: [PATCH 1/2] EuiBasicTable actions close their context menu when clicked. --- src/components/basic_table/collapsed_item_actions.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/components/basic_table/collapsed_item_actions.js b/src/components/basic_table/collapsed_item_actions.js index 05736e84715..766dd8cfa40 100644 --- a/src/components/basic_table/collapsed_item_actions.js +++ b/src/components/basic_table/collapsed_item_actions.js @@ -43,6 +43,11 @@ export class CollapsedItemActions extends Component { } } + onClickItem = (onClickAction) => { + this.closePopover(); + onClickAction(); + } + render() { const { actions, itemId, item, actionEnabled, onFocus, className } = this.props; @@ -72,7 +77,7 @@ export class CollapsedItemActions extends Component { key={key} disabled={!enabled} icon={action.icon} - onClick={action.onClick.bind(null, item)} + onClick={this.onClickItem.bind(null, action.onClick.bind(null, item))} > {action.name} From bbf5e22a0d292a27f651918a795885bfbc79381c Mon Sep 17 00:00:00 2001 From: CJ Cenizal Date: Tue, 31 Jul 2018 16:47:10 -0700 Subject: [PATCH 2/2] Changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0a175fc1a56..16dfc8a7516 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,8 +4,9 @@ **Bug fixes** -- Fixed `EuiXYChart` responsive resize in a flexbox layout ([#1041](https://github.com/elastic/eui/pull/1041)) +- Fixed `EuiSeriesChart` (previously `EuiXYChart`) responsive resize in a flexbox layout ([#1041](https://github.com/elastic/eui/pull/1041)) - `EuiInMemoryTable` no longer mutates the `items` prop array when sorting, adding deterministic sorting ([#1057](https://github.com/elastic/eui/pull/1057)) +- `EuiBasicTable` actions now close their context menu when clicked ([#1069](https://github.com/elastic/eui/pull/1069)) **Experimental breaking change**