Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting data-test-subj on EuiInMemoryTable #831

Closed
timroes opened this issue May 15, 2018 · 1 comment · Fixed by #836
Closed

Allow setting data-test-subj on EuiInMemoryTable #831

timroes opened this issue May 15, 2018 · 1 comment · Fixed by #836

Comments

@timroes
Copy link
Contributor

timroes commented May 15, 2018

We currently can't set data-test-subj which we need for the functional testing framework on EuiInMemoryTable. I think we should be able to set this attribute (or in general all data- attributes) on most of the components to one of the actual HTML elements, so we are able to properly do functional testing with EUI components.
@chandlerprall
Copy link
Contributor

Also related to #760

@chandlerprall chandlerprall mentioned this issue May 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extra props on EuiInMemoryTable and EuiBasicTable chandlerprall/eui
2 participants
@chandlerprall @timroes