Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Ensure gridStyles updates trigger a cell height recalculation #7811

Closed
mgadewoll opened this issue Jun 4, 2024 · 0 comments · Fixed by #8025
Closed

[EuiDataGrid] Ensure gridStyles updates trigger a cell height recalculation #7811

mgadewoll opened this issue Jun 4, 2024 · 0 comments · Fixed by #8025

Comments

@mgadewoll
Copy link
Contributor

Description

While working on this bugfix on EuiDataGrid we noticed that the gridStyles prop does not trigger a recalculation of cell heights.
While it's generally not expected to impact production (styles shouldn't change on the fly), it does show up in storybook and might create confusion that the grid does not update based on props as expected.

We should enable the fontSize and cellpadding props on gridStyles to be applied when changed.

Screenshot 2024-06-04 at 19 23 52

Acceptance criteria

  • gridstyles.fontSize and gridStyles.cellPadding trigger recalculation of EuiDataGrid cell heights (testable in Storybook via controls)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants