-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Change header cell popover menu trigger element to be the verticalBoxes
icon button
#7660
Comments
Some things to consider here:
|
Hey team, just wanted to check in on this issue and ask if it's still something that could be prioritized in the near term? We'd like to implement the ECS field descriptions functionality @ninoslavmiskovic mentioned above in Discover, but currently the a11y issue is an obstacle. |
@davismcphee Hey Davis, we weren't planning to work on this until next quarter. We'll see if we can work it into our schedule for the next week or two. |
Thanks for considering it! |
After having had a first look at this I think there are still some Accessibility/Usability questions to align on and I think we should align with @1Copenut to verify what expected output and functionality we need to ensure.
|
ℹ After aligning with @1Copenut I updated the POC solution and asked for a full accessibility check next to verify our changes work as expected. |
Summary
This request came up from the discussion in #7469.
There are cases where customers want to add interactive components like
EuiTooltip
s toEuiDataGrid
header cells to provide more context and display help text. This is currently impossible to achieve while keeping the header cells accessible. We've decided it would be worth changing the element we listen for click events on from the whole header cell to just the vertical boxes icon (with some padding added to reduce cursor/touch precision required).Acceptance criteria
EuiDataGrid
's header cell popover menus should open only when clicking on theverticalBoxes
icon button and not the whole header cellverticalBoxes
icon button should have adata-test-subj
attribute for easy referencing in automated testsThe text was updated successfully, but these errors were encountered: