Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New docs] Create stories for components starting with the letter D #7477

Closed
7 of 9 tasks
Tracked by #7405
tkajtoch opened this issue Jan 24, 2024 · 1 comment · Fixed by #7779
Closed
7 of 9 tasks
Tracked by #7405

[New docs] Create stories for components starting with the letter D #7477

tkajtoch opened this issue Jan 24, 2024 · 1 comment · Fixed by #7779
Assignees
Labels
New EUI site task A task associated with a larger Meta issue

Comments

@tkajtoch
Copy link
Member

tkajtoch commented Jan 24, 2024

Summary

Create Storybook playground stories for EUI components whose names start with the letter D. This is a part of #7405.

Components to create stories for:

  • EuiDataGrid
  • EuiDatePicker
  • EuiDelayHide
  • EuiDelayRender
  • EuiDescriptionList
  • EuiDescriptionListTitle
  • EuiDescriptionListDescription
  • EuiDraggable
  • EuiDroppable

Acceptance Criteria

  • Playground stories are created following the default story file format we're using
  • Story controls include all component props
    • If some props are complicated to get added, feel free to leave a TODO comment for now instead

Story file template

import React from 'react';
import type { Meta, StoryObj } from '@storybook/react';

const meta: Meta<COMPONENT_PROPS> = { // TODO: Replace COMPONENT_PROPS with the component props type
  title: 'Components/COMPONENT_EXPORT_NAME', // TODO: Replace COMPONENT_EXPORT_NAME with component export name
  component: COMPONENT, // TODO: Replace with the actual component import
  argTypes: {} // TODO: Setup arg types,
  args: {}, // TODO: Pass in default args
};

export default meta;
type Story = StoryObj<COMPONENT_PROPS>; // TODO: Replace COMPONENT_PROPS with the component props type

export const Default: Story = {};
@cee-chen
Copy link
Contributor

Let's strike EuiDataGrid from that list and create a separate issue for the tabular components (EuiDataGrid, EuiBasicTable and EuiInMemoryTable), since those are so complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New EUI site task A task associated with a larger Meta issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants