Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First modal example does not adequately focus the primary modal button #700

Closed
aphelionz opened this issue Apr 24, 2018 · 2 comments
Closed

First modal example does not adequately focus the primary modal button #700

aphelionz opened this issue Apr 24, 2018 · 2 comments
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Open https://elastic.github.io/eui/#/guidelines/modals in a new tab.
  2. Tab through the navigation to the main content pane.
  3. Tab to the "Show Component Code" button and press enter
  4. Tab to the first "Show Modal" button
  5. Press enter

Actual Result

The "Show Modal" button remains focused and the modal opens in front of the focused button

Expected Result

The "Save" button is auto-focused.

Category: #699: Elastic UI Modals Accessibility
Relevant WCAG Criteria: 3.2.2 Predictable on Input
@aphelionz aphelionz added accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels Apr 24, 2018
@aphelionz aphelionz mentioned this issue Apr 24, 2018
Closed
2 tasks
@snide snide added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Jun 8, 2018
@w33ble
Copy link
Contributor

w33ble commented Jul 10, 2018 •
edited
Loading

This is probably related, but I'm not sure if it should be a new issue or not. Since the modal body doesn't get focus, the escape hotkey also does not work to dismiss the modal, at least until you click inside the modal somewhere.

@chandlerprall
Copy link
Contributor

Modal guideline page no longer exists. Modal accessibility - including keyboard and screen reader support - is now being tracked in #3889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aphelionz @chandlerprall @snide @w33ble