Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 5 #6981

Open
j-m opened this issue Jul 21, 2023 · 8 comments
Open

Typescript 5 #6981

j-m opened this issue Jul 21, 2023 · 8 comments

Comments

@j-m
Copy link
Contributor

j-m commented Jul 21, 2023

Hey folks!

Just wondering, are there any plans to support typescript 5?

As more and more packages make the jump, we start missing out on more and more features (and security patches) - once packages migrate they don't tend to support older versions.

I've managed to patch-package most of my dependencies to avoid problems but I wanted to upgrade to Storybook 7 to find even it doesn't really support anything below 5.1.

As always, no pressure! Just curious to see if we can JFDI or whether we should start curating a list (if you haven't already)

EDIT: Storybook didn't intend to drop ts<5 and are looking at supporting ts 4

@JasonStoltz
Copy link
Member

JasonStoltz commented Jul 31, 2023

We agree that this is something we need to prioritize. However, we need to determine the best path forward as Kibana will not yet be on Typescript 5.

We will perform a spike to see how this works with Kibana.

@j-m
Copy link
Contributor Author

j-m commented Jul 31, 2023

You may be able to support Typescript 5 as a peer dependency without using any of its new features, i.e. support both! typescript: ~4.3 || ... || ~5.0 || ~5.1

@b3nshi
Copy link

b3nshi commented Oct 30, 2023

hello everyone, just wanted to know if there any update?

@JasonStoltz
Copy link
Member

@tkajtoch is spiking this out. Expect an update from him soon.

@tkajtoch tkajtoch self-assigned this Nov 2, 2023
@tkajtoch
Copy link
Member

tkajtoch commented Nov 6, 2023

We're actively working on getting EUI on TypeScript 5.

Here's the issue list you can check to track this effort:

I encountered issues last week while trying to update our prop-loader but will look into it again this week.

However, please keep in mind that you can already use EUI in applications running on Typescript 5. It will warn you during the install that it's incompatible (because we have typescript@4 set as a peer dependency), but I verified it works totally fine in React 18 and Next.js 13 based apps.

@j-m
Copy link
Contributor Author

j-m commented Nov 10, 2023

However, please keep in mind that you can already use EUI in applications running on Typescript 5. It will warn you during the install that it's incompatible (because we have typescript@4 set as a peer dependency), but I verified it works totally fine in React 18 and Next.js 13 based apps.

Could we do a release with multi-version support then? i.e. typescript: ~4.3 || ... || ~5.0 || ~5.1 || ...

@tkajtoch
Copy link
Member

The EUI codebase is already compatible with TypeScript 5.x. The reason we're currently labeling this as blocked is that our current props table generator, which we use for the EUI docs website, is incompatible with TS 5, and we're waiting until the new EUI website is up and running. You can track this effort in #7401.

Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants