Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBasicTable] Does not pass-thru unknown properties #679

Closed
pickypg opened this issue Apr 16, 2018 · 1 comment
Closed

[EuiBasicTable] Does not pass-thru unknown properties #679

pickypg opened this issue Apr 16, 2018 · 1 comment
Labels
bug

Comments

@pickypg
Copy link
Member

pickypg commented Apr 16, 2018

While reviewing a PR that made use of <EuiBasicTable>, I recommended that they apply data-test-subj="blah" to the table instead of a wrapping <div> and they noted that it didn't work.

Small issue, but it's inconsistent with other components.
@pickypg pickypg added the bug label Apr 16, 2018
@pickypg pickypg mentioned this issue Apr 16, 2018
Merged
7 tasks
@cjcenizal
Copy link
Contributor

Fixed by #836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snide @cjcenizal @pickypg