Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Need Icons for Online / Offline Instances #676

Closed
pickypg opened this issue Apr 16, 2018 · 4 comments · Fixed by #881
Closed

[Icons] Need Icons for Online / Offline Instances #676

pickypg opened this issue Apr 16, 2018 · 4 comments · Fixed by #881

Comments

@pickypg
Copy link
Member

pickypg commented Apr 16, 2018

For every component in the stack, we can sometimes detect three states in various parts of the UI:

  • Online
  • Offline
  • Probably Offline (e.g., haven't heard from it in awhile, but we do have some data in the selected time range)

Looking through the existing icons, I think that check or checkInCircleFilled and bolt are probably the closest thing to representing the first two, but I do not see a good one for the third one. Possibly reusing compute in some way that didn't depend on color may also help.

@cchaos
Copy link
Contributor

cchaos commented Apr 16, 2018

@pickypg Why wouldn't you use EuiHealth with "Online", "Offline", "~Offline" written out explicitly?
screen shot 2018-04-16 at 14 25 29 pm

@pickypg
Copy link
Member Author

pickypg commented Apr 16, 2018

That's a possibility, but it limits our ability to display different concerns. That is literally what we do currently (but we have historically used gray for the offline variant):

image

but I think that this may cause confusion with other parts of Elasticsearch and Kibana where the status color itself has meaning. A "green" online node may be confused as Elasticsearch is green for that node (which is not a thing).

This is compounded for Kibana, which actually has a colored state per instance, which would be different from the ~Offline status at least and Offline as well because that's something that we would be inferring.

I suspect that these three types of icons would also be useful for various management UIs, particularly anything that deals with a third party service to show the varying states.

@cchaos
Copy link
Contributor

cchaos commented May 25, 2018

@pickypg Icons have shipped with latest release

@pickypg
Copy link
Member Author

pickypg commented May 25, 2018

Nice, thanks! /cc @justinkambic @ycombinator @ruflin @tsullivan for awareness relative to future efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants