-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to navigation components in support of Kibana nav redesign #6759
Comments
Are there changes that need to go into EUI components as part of the new header for serverless projects? Specifically, creating the nav show/hide button looks like it is to be done with |
EUI should be handling this on our end. |
Using this approach means significantly less headache with npm exports and staying up to date on main (especially since we have several tech debt items such as node/React versions occurring) while still allowing us to remain flexible and tweak the component as-needed if specific props aren't working as expected. |
Roger that regarding an internal component. On the topic of top header, I suspect we need a separate issue to capture the collapse button design. I don't know that there are other new changes (perhaps breadcrumbs 🤔 ), but I will suss those out. cc:/ @MichaelMarcialis |
@ryankeairns: Aside from what is mentioned in the original comment above (re: inclusion of deployment/project and space as part of breadcrumbs), I don't believe the current designs suggest any changes to breadcrumbs other than to use the The header remains largely the same for both expanded and collapsed navigation modes in larger viewport sizes. The only difference in the two is the icon being used to represent the collapse/expand action. Where the header (and navigation) does start to exhibit some more significant change is at smaller viewport sizes (see Figma examples). |
Michael, you're a mind-reader! I was just about to ask for mobile views :) |
So I ended up going with option 5 (a brand new component called There are a couple UX questions I wanted to iron out before writing more tests and un-drafting the PR, such as:
@tsullivan, in particular I'd love to chat at next week's meeting about the new API and confirm that it'll work for your use case / doesn't have any missing props / won't be too annoying to use or migrate to. Thanks y'all! |
Looking forward to the review. Looking really good! |
Hey, @cee-chen. Here are some quick answers to your questions before our review today.
We spoke about this in Slack, but I'll paste my response here as well for visibility. My original intent for root level navigation items was that they could function as either an accordion or a link, but not both (to keep it simple and predictable for users). So in the case of the solutions (like Observability and Security), their root level item was intended to function only as an accordion toggle. That said, I know you mentioned having implemented it with the possibility for both, so we can evaluate further in our review.
Correct. Based on the current designs there could be a maximum of three nested accordion levels. However, the navigation items and their location/depth is changing on a daily basis at the moment while the solutions are ironing things out. While I can't guarantee it will be more or less than that, my hope is that we never or rarely go beyond a third level, unless absolutely necessary.
Yes. I've added a quick example of the selected state in various levels and accordion states below. The thinking is that each individual item should be able to support a selected state. If the currently selected item has had its parent accordion collapsed by the user, that parent should be given the selected state while collapsed.
Good question. If there are style implications involved when determining if the navigation should allow only one or all accordions to be opened simultaneously (as I suspect there may be, namely the flexbox styles), it may make sense for this option to be a prop on the EUI side. If I'm wrong though, and there are little to no style implications, then I suppose there's no harm in having the Shared UX team implement that restriction. |
@ryankeairns Quick reminder to move out the requested |
This issue will close once #7034 merges, as a wholly usable MVP will be available for Kibana at that point. As a heads up, here are several things we skipped implementing as a conscious choice:
|
As part of the upcoming initiatives, we were tasked with redesigning Kibana's main navigation to accommodate new workstream-driven info architectures (IA). This redesigned navigation aims to unify the existing main and solution-level navigations into a singular navigation. Here are links to our latest designs:
The Platform UX team's proposal largely utilizes functionality from the
EuiCollapsibleNav
andEuiSideNav
components, but it does deviate in a number of key ways as outlined below.Implementation considerations
Before getting into the design details, there is an open question as to how we proceed with the implementation. Some options that come to mind are:
main
.Depending on how we split the work in this issue, we may find that the visual design changes, for example, are safe to push to main. That said, it would be helpful to see them in the flesh and try things out in Kibana before committing to main. With this bit of uncertainty, option 3 seems a good path for trying things on in a low-risk manner.
Currently, there are two nav versions in Kibana. One for the current design and a second that is the beginning of this new design (emphasis on chrome service/API not UI design changes). It may be that Shared UX (i.e. Kibana Eng) want to apply this new/alternative package to only the latter for initial launch.
Suggestion
For item 3, the right-aligned icon is likely to be straightforward and relatively small. The new collapsible design will be the largest of all items in this effort and needs further discussion. Given that, I will mark it as hold until we get final alignment from our Product and UX peers.
Design changes
The sections below provide a component-level comparison of key deviations between the existing EUI components and the newly proposed navigation redesign. At a high level, the tasks can be summarized as follows:
Tasks - Visual design changes
Tasks - Functional enhancements
EuiCollapsibleNav
DifferencesFunctional enhancements
EuiCollapsibleNav
currently offers a docked option, which allows the navigation to operate similar to a push flyout, where the navigation occupies and shares space with the adjacent body content (rather than being overlaid). As the new navigation designs are planning to absorb the responsibilities of both the current Kibana main navigation and solution-level navigations, we proposed that the new navigation design be an ever-present fixture on the page (almost as if it were permanently docked).EuiContextMenu
-based navigation, which would utilize nested menus to mimic the nested accordions in the larger expanded navigation designs.Visual changes
EuiCollapsibleNavGroup
components appear to have a top border applied to visually separate siblings. The navigation redesign proposes we omit these borders to cut down on the visual noise in situations where many navigation groups are present.EuiCollapsibleNavGroup
button styles in the redesigned navigation propose different hover and current state styles, different padding, and different spacing between icon and title.The current accordion arrow button within
EuiCollapsibleNavGroup
appears to take anarrowRight
icon and rotate it 90 degrees to achieve the collapsed/expanded accordion effect. While this effect works great for left-aligned accordion arrows, it feels unexpected when right-aligned (which causes the collapsed right-facing arrow to look more like it will open a menu or navigate you forward, rather than open an accordion). The redesigned navigation also uses right-aligned arrows to indicate the accordion state, but instead of directing them right/down, they are down/up (better indicating that the panel will be sliding down or up with the accordion behavior). The designs also propose a smaller arrow icon (12px) and a low contrast color for the arrow when the accordion is closed to avoid visually overwhelming users if a lot of accordions are visible.EuiSideNav
DifferencesFunctional enhancements
For non-accordion
EuiSideNavItem
components, the new designs account for the possibility of a right-aligned appended icon. Specifically, this will be used for the low contrast 12px icon indicating an external links in the navigation.Visual changes
EuiSideNavItem
styles in the redesigned navigation propose different hover and current state styles, and different padding.The current accordion arrow icon that conditionally appears within
EuiSideNavItem
appears to use hard-codedarrowRight
andarrowDown
icons to achieve the collapsed/expanded accordion effect. For the same reasons I detail in theEuiCollapsibleNavGroup
accordion comments above, the redesigned navigation suggests usingarrowDown
andarrowUp
icons instead. The designs also propose a low contrast color for the arrow when the accordion is closed to avoid visually overwhelming users if a lot of accordions are visible.When a
EuiSideNavItem
component with nested items is expanded, we currently show prepended vertical lines and horizontal ticks to help users better visualize the hierarchy of the items in the list. The redesigned navigation maintains this general concept, but alters it slightly by removing the horizontal ticks altogether (to reduce visual noise) and only using the vertical lines to indicate hierarchy. It also aligns the left side of the vertical line with the left edge of the parent text (rather than being kicked in 8px).Nested
EuiSideNavItem
text receives a subdued color currently. In the redesigned navigation, we're proposing that these nested items maintain the standard text color.When a
EuiSideNavItem
component with nested items is expanded, the redesigned navigation proposes adding an additional 16px of spacing at the bottom of the opened accordion to provide addition spacing between the end of the accordion's contents and the next item in the list.EuiBreadcrumbs
Differences➡️ Moved breadcrumb work to #7015
Functional enhancements
As part of our design explorations in the main navigation, we played with a few possibilities for where to place project links, cloud deployment links, and the space selector. We ultimately landed on the idea to prepend them as part of the breadcrumbs, as that fit very well hierarchically. Ideally, we'd like the ability to have these prepended breadcrumb items that will trigger a popover when clicked.
CCing @tsullivan in case there's anything we missed.
The text was updated successfully, but these errors were encountered: