-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPageHeader] The focus order of rightSideItems
does not correspond to the logical processing sequence
#6693
Comments
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
This comment was marked as outdated.
This comment was marked as outdated.
Transferring to the EUI repo - this needs to be addressed at the |
rightSideItems
does not correspond to the logical processing sequence
After reviewing, I don't think this is a bug. In terms of accessibility, @1Copenut do you mind throwing in your 2 cents? I'm inclined to say it's not an issue and if the team wanted to update the direction of the elements, they have the ability to. I don't think this requires any changes in EUI. |
This is an accessibility issue, not a "bug" per se, but it is definitely an issue and the default needs to be changed. Just because consumers can override it via props doesn't mean they will, and the role of EUI is to set good accessibility defaults and best practices. Instead of using |
I +1 to @cee-chen comment here. I was reading through Technique C27: Making the DOM order match the visual order to double-check. Visually English is top to bottom and left to right, so moving out of the left navigation users have a reasonable expectation the |
Thank you both for the explanations here! I'll move forward with this info. |
WCAG success criterion 2.4.3 - focus order - A
Steps to reproduce
Actual Result
Expected Result
Meta Issue
n.a.
Kibana Version:
8.3
OS:
Microsoft Windows 10 Enterprise (64-bit)
Browser:
Google Chrome 109.0.5414.75 (64-Bit)
Screen reader:
n.a.
Relevant WCAG Criteria:
WCAG success criterion 2.4.3 - focus order - A
https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html
Relevant ARIA spec:
n.a.
The text was updated successfully, but these errors were encountered: