Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[link components] make isDomainSecure configurable #6232

Closed
chandlerprall opened this issue Sep 12, 2022 · 3 comments
Closed

[link components] make isDomainSecure configurable #6232

chandlerprall opened this issue Sep 12, 2022 · 3 comments

Comments

@chandlerprall
Copy link
Contributor

Right now isDomainSecure is hard coded to flag elastic.co & subdomains as secure for the purpose of adding rel=noreferrer to non-elastic links.

Instead of the hard-coded value, this should be configurable by the application; likely by adding a function to EuiProvider that can provide this true/false logic, defaulting to () => false and we'll re-add the elastic.co logic to Kibana's use of that provider

@chandlerprall chandlerprall changed the title make isDomainSecure configurable [link components] make isDomainSecure configurable Sep 12, 2022
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@cee-chen
Copy link
Contributor

Noting for historical recordkeeping: this was actually closed/resolved by #6535 (removing isDOmainSecure entirely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants