Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] React 18 Support #6182

Closed
10 tasks done
chandlerprall opened this issue Aug 25, 2022 · 1 comment · Fixed by #7012
Closed
10 tasks done

[Meta] React 18 Support #6182

chandlerprall opened this issue Aug 25, 2022 · 1 comment · Fixed by #7012
Assignees
Labels
dependencies Pull requests that update a dependency file meta

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Aug 25, 2022

Description rewritten by @tkajtoch.

Currently, EUI doesn't support React 18, and we noticed some of the components are behaving unexpectedly or are entirely broken when running on the latest React runtimes with strict mode enabled. We know this may block our users from upgrading to the latest and greatest, and we decided to prioritize the EUI upgrade process to address this issue.

Goals

  • Allow users to integrate EUI components with React 18 applications or migrate their existing applications using EUI to React 18
  • Keep supporting React >=17 versions in new releases for the time being
  • Upgrade EUI docs application to run on the latest React 18 version
  • Maintain the same component APIs and props (internal components structure may change)
  • Update our testing frameworks to run tests on React 18 and fix any broken tests
  • Provide upgrade instructions if necessary

Acceptance Criteria

  • All EUI components work according to specification, and their behavior doesn't change between React 18 and older React versions
  • EUI docs app runs on React 18
  • All unit and e2e tests are passing
  • There are no breaking changes to the components' usage or props (stricter prop definitions are allowed - e.g. around the children prop)
  • All dependencies using React are updated to versions supporting React 18

Definition of done

  • All EUI components are tested using already built automated test suites as well as manually, and any necessary fixes are implemented
  • All linked issues to this meta issue are done and closed
  • Changes are merged from a feature branch to main
  • EUI supporting React 18 is released


Related issues

@cee-chen cee-chen added dependencies Pull requests that update a dependency file and removed developer experience react 18 labels Apr 24, 2023
@cee-chen cee-chen changed the title [Meta] issues with EUI + React 18 [Meta] EUI + React 18 Apr 25, 2023
@tkajtoch tkajtoch changed the title [Meta] EUI + React 18 [Meta] React 18 Support May 16, 2023
@tkajtoch tkajtoch mentioned this issue Jul 28, 2023
15 tasks
@cee-chen
Copy link
Member

cee-chen commented Aug 1, 2023

Follow-up support items:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file meta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants