Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color palette doc is wrong for dark themes #605

Closed
cchaos opened this issue Mar 30, 2018 · 1 comment · Fixed by #1691
Closed

Color palette doc is wrong for dark themes #605

cchaos opened this issue Mar 30, 2018 · 1 comment · Fixed by #1691
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries

Comments

@cchaos
Copy link
Contributor

cchaos commented Mar 30, 2018

It's still using the regular theme color variants.

screen shot 2018-03-30 at 14 58 10 pm
@cchaos cchaos added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Mar 30, 2018
@snide
Copy link
Contributor

snide commented Mar 30, 2018

Yeah. I need the theme passed down into the component lower level component so I can tell it which palette to pull from. Right now it's only top at the chrome level.

@snide snide added the bug label Mar 30, 2018
@snide snide mentioned this issue Apr 30, 2018
Closed
44 tasks
@snide snide mentioned this issue Oct 31, 2018
Merged
2 tasks
@snide snide mentioned this issue Mar 7, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dark mode redux, fix dark mode docs snide/eui
2 participants
@snide @cchaos