Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Pill traversal and safer deletion interaction #590

Closed
cjcenizal opened this issue Mar 28, 2018 · 3 comments · Fixed by #6699
Closed

[EuiComboBox] Pill traversal and safer deletion interaction #590

cjcenizal opened this issue Mar 28, 2018 · 3 comments · Fixed by #6699

Comments

@cjcenizal
Copy link
Contributor

Per #567 (comment):

I think the "pill" should be tabable. And that you should have to tab through them to get to the input. Right now it's pretty hard to get to them with your keyboard. There's no way to delete the first item of three with the keyboard. You have to delete all or nothing.

Similarly, for your backspace mechanic, I'd suggest using the first Backspace to do a "shift-tab" action, that actually selects the item, then the second backspace actually deletes it. This prevents people from inadvertently deleting things by accident. It's a small thing, but really helps these kinds of interactions. Here's an example of one I built awhile ago. The "blue" state is the first backspace, and then the second backspace confirms it. If you end up added something like that, i can think up some proper styling if you pass over an isSelected prop on the pill itself.

@anishagg17
Copy link
Contributor

anishagg17 commented Mar 16, 2020

Also, hitting delete key doesn't delete the currently focused element

Hnet com-image (6)

@chandlerprall
Copy link
Contributor

chandlerprall commented Sep 18, 2020

Tabbing through pills is now supported. However, the rest of the reported issue is still valid - plus now if you tab to a pill and hit backspace it removes the last pill not the one selected 😢 (see the previous comment, which has a screen grab of this in action). Hitting space will remove the highlighted pill.

@cchaos cchaos changed the title EuiComboBox: Pill traversal and safer deletion interaction [EuiComboBox] Pill traversal and safer deletion interaction Sep 19, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants