Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCallout][COGNITION]: Document consumer responsibility with header prop #5884

Open
1Copenut opened this issue May 6, 2022 · 6 comments
Open

Comments

@1Copenut
Copy link
Contributor

1Copenut commented May 6, 2022

Description

@cchaos and @1Copenut were discussing the callout heading prop defaulting to a P tag in PR #5870 5870. We opted to leave the default as a P tag for now and open an exploratory ticket for improved awareness. We want consuming applications to be aware callouts should have a relevant heading that is properly nested (H4 if under an H3 for example) when it makes sense.

Making sure callouts have proper headings is especially important if the text is styled in such a way as to suggest prominence or greater importance than paragraph text.

There are two items we'd like to look at specifically:

  1. Callout guidance in the EuiCallout docs page outlining why a properly nested heading is important for assistive technology. I'll list some relevant links below.
  2. Making the heading prop required by consuming apps in the future. This feels like a good defensive coding strategy. It also has potential to be a breaking change.

Guidance

@cchaos
Copy link
Contributor

cchaos commented May 6, 2022

Task 2 will absolutely be a breaking change 😅 .

@1Copenut
Copy link
Contributor Author

1Copenut commented May 6, 2022

So labeled! I appreciate the size of the task, and that moving this ahead will require coordination and a good plan.

@1Copenut 1Copenut changed the title [EuiCallout][COGNITION]: Document consumer responsibility with `header prop [EuiCallout][COGNITION]: Document consumer responsibility with header prop May 6, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@1Copenut 1Copenut reopened this Apr 22, 2024
@JasonStoltz
Copy link
Member

Let's focus on just getting an update to documentation here.

@JasonStoltz JasonStoltz assigned 1Copenut and unassigned 1Copenut Apr 29, 2024
@JasonStoltz JasonStoltz assigned 1Copenut and unassigned 1Copenut May 13, 2024
@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants