Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiAccordion][AXE-CORE]: Review the accordions that create a fieldset for ARIA attribute violation #5767

Closed
Tracked by #5265
1Copenut opened this issue Apr 6, 2022 · 3 comments

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Apr 6, 2022

Description

The EuiAccordion component has three critical axe-core violations appearing in browser and CI scans with the latest version of the plugin. The issues are showing up in two ways, and will be addressed in separate tickets.

This issue is related to the "Styled for Forms" accordion examples. These wrap the accordion in a <legend> tag that's further nested in a <fieldset> tag. The axe checker is complaining about this because legends can't contain the aria-expanded attribute.

I would like to review this pattern. The MDN docs state a fieldset is meant to wrap related elements like radio buttons or checkboxes inside a form. The examples provided show/hide a form, but the button trigger is not included. I feel it would be better to not switch to a fieldset + legend, but that's a first take. I'll bring this up with the EUI team for context and history I might be missing.

Guidance

Prior Art


Screen Shot 2022-04-06 at 1 32 07 PM

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@github-actions
Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants