Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiAccordion][AXE-CORE]: Review the interactive content in trigger pattern for ARIA attribute violation #5766

Closed
Tracked by #5265
1Copenut opened this issue Apr 6, 2022 · 6 comments

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Apr 6, 2022

Description

The EuiAccordion component has three critical axe-core violations appearing in browser and CI scans with the latest version of the plugin. The issues are showing up in two ways, and will be addressed in separate tickets.

This first issue is based on a DIV that's a sibling to the button that expands and collapses the accordion. This DIV needs to have two attributes removed:

  • aria-expanded
  • aria-controls

These attributes belong to the button and are set correctly. We'd need to confirm we haven't overridden screen reader behavior or broken tests that rely on the attributes for hooks.

Guidance


Screen Shot 2022-04-06 at 1 09 42 PM

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@JasonStoltz
Copy link
Member

@1Copenut Can you take a look at this and see if it's just an issue in docs?

@1Copenut
Copy link
Contributor Author

@JasonStoltz This is still an issue. We do allow users to pass div | legend | button to the buttonElement prop. In that case the rendered HTML is holding onto those ARIA attributes that aren't valid on <div> or <legend> tags.

Fixing this will require a decent-sized refactor to move the ARIA attributes to the right element if users opt to override the default prop values. Still valid, breaking change.

@JasonStoltz
Copy link
Member

@1Copenut Thank you for looking at that. Do you mind adding a size and priority to this issue?

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants