Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox][COGNITION]: Focusable close buttons should not have a nested element with tabindex #5545

Closed
Tracked by #5265
1Copenut opened this issue Jan 18, 2022 · 0 comments · Fixed by #5560
Closed
Tracked by #5265

[EuiComboBox][COGNITION]: Focusable close buttons should not have a nested element with tabindex #5545

1Copenut opened this issue Jan 18, 2022 · 0 comments · Fixed by #5560
Assignees
@1Copenut
Labels
accessibility - automated accessibility - cognition accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility

Comments

@1Copenut
Copy link
Contributor

Description

Our EuiComboBoxPill component uses the EuiIcon to create the X close button. It's wrapped in a <button> so the icon cannot have a tabindex. We should remove it from line 77 of combo_box_pill.tsx so we can remove quite a few axe-core errors from the Combo box component.

Guidance

Screenshots

Screen Shot 2022-01-18 at 2 26 36 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1Copenut 1Copenut

Labels
accessibility - automated accessibility - cognition accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiComboBox][KEYBOARD]: Removing tabindex -1 from EuiComboboxPill SVG
1 participant
@1Copenut