Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiComboBox][AXE-CORE]: aria markup needs to be adjusted for best screen reader experience #5301

Closed
Tracked by #5265
1Copenut opened this issue Oct 20, 2021 · 0 comments · Fixed by #5636
Closed
Tracked by #5265

[EuiComboBox][AXE-CORE]: aria markup needs to be adjusted for best screen reader experience #5301

1Copenut opened this issue Oct 20, 2021 · 0 comments · Fixed by #5636
Labels
accessibility - automated accessibility - cognition accessibility - screen reader accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Oct 20, 2021 •
edited
Loading

Description

Our EuiComboBox component has two uses of the term "listBox" that need to be adjusted to "listbox" in all lower case. The component container, combobox, and listbox elements must have relevant aria-markup for a the WAI-ARIA 1.2 editable combobox with list autocomplete example or screen reader users may have a more difficult time interacting with our component.

The listbox also needs an accessible label. See the work done as part of #5292 for the way it was updated on EuiSuperSelect.

Guidance

Screenshot

Screen Shot 2021-10-20 at 4 50 44 PM
@1Copenut 1Copenut mentioned this issue Oct 20, 2021
Closed
22 tasks
@1Copenut 1Copenut changed the title [EuiComboBox][AUTOMATION]: aria markup needs to be adjusted for best screen reader experience [EuiComboBox][AXE-CORE]: aria markup needs to be adjusted for best screen reader experience Oct 20, 2021
@1Copenut 1Copenut mentioned this issue Nov 11, 2021
Merged
10 tasks
@1Copenut 1Copenut mentioned this issue Jan 18, 2022
Closed
@1Copenut 1Copenut self-assigned this Jan 31, 2022
@1Copenut 1Copenut removed their assignment Jan 31, 2022
@1Copenut 1Copenut mentioned this issue Feb 14, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility - automated accessibility - cognition accessibility - screen reader accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiComboBox] Revising to WAI-ARIA 1.2 spec.
1 participant
@1Copenut