Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDragAndDrop][AXE-CORE]: Nested drag and drop buttons will not be announced by screen readers #5294

Closed
Tracked by #5265
1Copenut opened this issue Oct 20, 2021 · 1 comment · Fixed by #5568
Closed
Tracked by #5265
Assignees

Comments

@1Copenut
Copy link
Contributor

Description

The EuiDragAndDrop has two instances where DIVs that are acting as button triggers have nested <button> elements. These buttons are throwing axe errors because they're native focusable elements nested in other focusable elements. We should remove the button if possible. The draggable divs contain their own label.

Guidance

Screenshots

Screen Shot 2021-10-20 at 2 29 54 PM


Screen Shot 2021-10-20 at 2 29 35 PM

@1Copenut 1Copenut changed the title [EuiDragAndDrop][AUTOMATION]: Nested elements that can take focus will not be announced by screen readers [EuiDragAndDrop][AUTOMATION]: Nested drag and drop buttons will not be announced by screen readers Oct 20, 2021
@1Copenut 1Copenut changed the title [EuiDragAndDrop][AUTOMATION]: Nested drag and drop buttons will not be announced by screen readers [EuiDragAndDrop][AXE-CORE]: Nested drag and drop buttons will not be announced by screen readers Oct 20, 2021
@1Copenut 1Copenut self-assigned this Dec 29, 2021
@1Copenut
Copy link
Contributor Author

@miukimiu I've been working on the drag and drop interactive elements today, and wanted to get your opinion on the following solution in progress.

The axe accessibility plugin was throwing an error when we had the interactive button inside the draggable container, so my idea was to add the custom drag handles as a sibling element to the interactive one. It's rough but gets us past the accessibility challenge and gives hooks for design adjustment.


Screen Shot 2022-01-25 at 4 46 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant