Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover][MOBILE]: Consider adding a close button to our popovers for mobile screen reader users #5282

Closed
1Copenut opened this issue Oct 18, 2021 · 4 comments · Fixed by #6567

Comments

@1Copenut
Copy link
Contributor

Description

Our EuiPopover component relies on users pressing ESC to close the modal. I'd like to explore adding a focusable Close button to the component. It could be an optional prop so we can turn it off, but I think this would be a big benefit for mobile screen reader users.

As the component behaves today, users have to double tap the button that opened the popover. If users can't see their screen it might be challenging to discover that button a second time.


Screen Shot 2021-10-18 at 3 07 22 PM

Guidance

@ghudgins
Copy link

ghudgins commented Mar 29, 2022

++ to this issue for a Discover case: this popover doesn't look closeable in Discover (reported by @bvader )
image

CC @andreadelrio & @VijayDoshi

@VijayDoshi
Copy link

++ the current modal behavior is not very friendly to close. A close affordance would be very useful. In the case of the Discover popup the width of the dialog is also not ideal.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@daveyholler
Copy link
Contributor

Per EUI team discussion, we'll solve this by adding instructions, "... or click outside"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants