Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps] Pin typescript to ~ not ^ #5146

Closed
j-m opened this issue Sep 6, 2021 · 1 comment · Fixed by #5182
Closed

[Deps] Pin typescript to ~ not ^ #5146

j-m opened this issue Sep 6, 2021 · 1 comment · Fixed by #5182
Assignees

Comments

@j-m
Copy link
Contributor

j-m commented Sep 6, 2021

Typescript, surprisingly doesn't follow semver (microsoft/TypeScript#14116) but npm's ~ accuracy follows their policy of non-breaking patch (equivalent) changes.
For example, in typescript 4.4 the type of error in a catch clause is no longer any but unknown.
While this may not affect EUI directly, as typescript is a peer dependency, npm 7 complains that I'm installing 4.2 not 4.4.
My expectation would be for EUI to release a major version when you use a new typescript "minor", but I understand that this may be an unreasonable request, this is a highly debated (heated) topic in the npm community.

@thompsongl
Copy link
Contributor

Yeah using ~ makes sense, I think. I also think that would be a breaking change because some consumers would need to downgrade the version they're using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants