-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a (dual) range component #496
Comments
@cchaos is working on some of this now. Caroline, do you mind posting some screens? We'll get them into components in the next couple weeks. |
I'm changing this from designer to engineer because the styles are now in there via #932, but a custom component needs to be built to support the dual functionality. |
👍 We need something similar in the GIS-app. We need it to select a min/max zoom range, and select min/max size-ranges for data-driven styling. |
In regards to the API, how much parity will we need with the single-knob version? That is, I assume things like |
The feeling is that it would look, behave, and have similar props to the range slider that exists now, but with 2 values (min and max) that might also bring with it some validation. Perhaps it's easier to add more options to the current slider to allow for 2 values to be passed back versus trying to duplicate into a new component? |
It's certainly possible to extend the functionality of |
I think moving away from the |
If we don't use input I think it makes a lot of to roll a new component for the dual sliders. Target the same API surface with props for min/max changed, but the underlying code should be vastly different. |
Summary of a Zoom with @chandlerprall just now:
|
Sounds good to me. When you create the docs part can you pull the current EuiRange out of the Form controls page and just create a new one dedicated to both EuiRange and EuiDualRange? Also, we should consider some DRY techniques that would allow both components to share some internals but leave the specific dual vs singular logic to the individual components. |
Agreed. And I did see your comment in #1461 related to documentation, so that will be part of the dev. |
Summary of a Zoom with @cchaos just now: In terms of an API, the two sliders have the ability to have the same surface, but the space and positioning limitations introduced with the dual case require some design changes. Tooltips are likely to either overlap with each other or extend beyond the intended container (or browser window). The left/right positioning logic in place doesn't remedy this. Given that the associated text/number inputs are already the recommended method to specify precise values, we decided to forgo tooltips and have implementers rely on the inputs to show exact values. |
It would be nice to have a range slider in EUI, i.e. a slider with two knobs, that specify a minimum and maximum value. We currently use different implementations across Kibana (Tag Cloud options, Input Control vis), that should rather be implemented via EUI.
The text was updated successfully, but these errors were encountered: