-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] track re-renders from hooks #4294
Comments
Alteranatively we could evaluate using the performance API where it might be more appropriate. |
@VladLasitsa cannot assign it to you, but could you please take it? |
Ok, I'll take it, but I can't assign it to myself either |
Done 😉 |
I'm just curious why we cannot profiling |
With heavy hooks usage for caching computed values, it isn't enough to know when a component re-rendered, but if a |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
This is definitely something we still want. Leaving unassigned in case someone else is interested in picking it up before we can get to it. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
The data grid relies heavily on React hooks to maintain/cache various states and values. In many cases it is trivially simple to trigger unnecessary re-computations and re-renders of these hooks. The data grid should be given a new
debugPerformance
prop that, when enabled,console.log
s when various hooks trigger, and ideally can provide a reason.There are some existing browser/react extensions/hacks that can provide the same or similar information, but requiring setting those up, especially for downstream projects like Kibana, are complicated and time consuming.
The text was updated successfully, but these errors were encountered: