Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Remove capitalization from boolean schema #4126

Closed
andreadelrio opened this issue Oct 8, 2020 · 3 comments · Fixed by #4753
Closed

[EuiDataGrid] Remove capitalization from boolean schema #4126

andreadelrio opened this issue Oct 8, 2020 · 3 comments · Fixed by #4753

Comments

@andreadelrio
Copy link
Contributor

andreadelrio commented Oct 8, 2020

We currently capitalize cells under the boolean schema. I think it'd make more sense to have it in lowercase. The ML recently sent a PR doing this in Kibana, probably a good idea to do it on our side too.

image

Relevant file

&.euiDataGridRowCell--boolean {

@cchaos
Copy link
Contributor

cchaos commented Oct 8, 2020

I can a reason for wanting both, so I'd say that this should be a configurable option. It could even be a blanket option across all schemas in terms of deciding what text-transform to use (if any).

@Dishebh
Copy link
Contributor

Dishebh commented Dec 10, 2020

@cchaos @andreadelrio shall I give text-transform none here as is done in ML?

@hetanthakkar
Copy link
Contributor

@cchaos I've submitted a PR for this issue. Could you please review it!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants