Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component for surfacing long errors in EuiToasts #393

Closed
cjcenizal opened this issue Feb 13, 2018 · 4 comments
Closed

Create component for surfacing long errors in EuiToasts #393

cjcenizal opened this issue Feb 13, 2018 · 4 comments
Assignees

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Feb 13, 2018

As temporarily addressed in #392, toasts can sometimes contain long errors like this:

image

Toasts are intended to contain very small amounts of content. Because these errors can grow to be very long, it's better to surface them inside a larger container like a modal. It'd be great if we could create a component, e.g. EuiToastError which will present the user with a brief description of the error and a button for seeing the full error. Clicking this button should open the error in a modal with a "Copy to clipboard" button.

@chandlerprall
Copy link
Contributor

Closing this issue. The design team is doing housekeeping against our issues and closing items without much recent activity. Feel free to reopen if you still have issues or feel this is in error.

@cjcenizal
Copy link
Contributor Author

@chandlerprall This is a very common problem in Kibana. I'm open to tracking it either here or in Kibana, whichever you prefer.

@snide
Copy link
Contributor

snide commented Oct 6, 2018

It's ok to keep this one open. I know it's a pain point. I've been thinking that maybe Kibana just needs an "error page" that you can go to and get the long form output of any specific error. Think it'd be useful beyond just this toast application (thinking about forms with detailed errors as well). Maybe something we can brainstorm at EAH.

@cchaos
Copy link
Contributor

cchaos commented Feb 26, 2019

This is preventing the conversion of Kibana's Notifier to the global toast service. We need to come up with a plan/component/pattern to handle this type of error surfacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants