Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasPropName utility errors on null values #3301

Closed
chandlerprall opened this issue Apr 10, 2020 · 0 comments · Fixed by #3303
Closed

hasPropName utility errors on null values #3301

chandlerprall opened this issue Apr 10, 2020 · 0 comments · Fixed by #3303

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Apr 10, 2020

If a null value gets to i18n_util.tsx::hasPropName an error is thrown

function hasPropName(child: Child): child is { propName: string } {
  return typeof child === 'object' && child.hasOwnProperty('propName');
}

This should be reproduced with a unit test before fixing. Haven't tested, but I believe this will error:

<EuiI18n token="blah" default="{arg}" values={{ arg: null }}

Originally posted by @chandlerprall in #2891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant