Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFormRow] doesn't always wire up the label and input #3037

Closed
myasonik opened this issue Mar 10, 2020 · 3 comments
Closed

[EuiFormRow] doesn't always wire up the label and input #3037

myasonik opened this issue Mar 10, 2020 · 3 comments
Labels
accessibility bug

Comments

@myasonik
Copy link
Contributor

As discovered during automated testing, EuiFormRow doesn't work when there is anything in between it and the form component breaking the label association.
@myasonik
Copy link
Contributor Author

myasonik commented Mar 10, 2020 •
edited
Loading

@thompsongl Just by the shape of the issue, I wonder if this is similar to #2709?

@myasonik myasonik mentioned this issue Mar 10, 2020
Open
1 task
@thompsongl
Copy link
Contributor

Perhaps. The cloneElement bit in EuiFormRow will pass the id to nested elements, whatever they are, so it's possible the form element never gets it.

@cchaos cchaos changed the title EuiFormRow doesn't always wire up the label and input [EuiFormRow] doesn't always wire up the label and input Mar 18, 2020
@myasonik myasonik mentioned this issue Apr 1, 2020
Closed
@cchaos
Copy link
Contributor

cchaos commented Sep 19, 2020

#3218 is a more detailed version of this.

@cchaos cchaos closed this as completed Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cchaos @thompsongl @myasonik