Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiCode & EuiCodeBlock Jest compatibility #2842

Closed
thompsongl opened this issue Feb 10, 2020 · 1 comment · Fixed by #3405
Closed

EuiCode & EuiCodeBlock Jest compatibility #2842

thompsongl opened this issue Feb 10, 2020 · 1 comment · Fixed by #3405
Assignees
@thompsongl
Labels
testing Issues or PRs that only affect tests - will not need changelog entries

Comments

@thompsongl
Copy link
Contributor

thompsongl commented Feb 10, 2020 •
edited
Loading

As of #2820 (v19.0.0) EuiCode and EuiCodeBlock use a React portal to render content. In Kibana, this causes failures in several snapshot tests, giving:

Portals are not currently supported by the server renderer. Render them conditionally so that they only appear on the client render.

Initial thought: we may want to provide a .testenv. mock to bypass createPortal.
@thompsongl thompsongl added testing Issues or PRs that only affect tests - will not need changelog entries assign:engineer labels Feb 10, 2020
@thompsongl
Copy link
Contributor Author

Currently mocked as part of elastic/kibana#57284, which is a prereq for actually being able to consume test-env mocks in Kibana

@thompsongl thompsongl self-assigned this Apr 27, 2020
@thompsongl thompsongl mentioned this issue Apr 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thompsongl thompsongl

Labels
testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiCodeBlockImpl] element creation event; testenv mock for tests thompsongl/eui
1 participant
@thompsongl