We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of the EuiIcon icons are missing the viewBox attribute, which causes them to not render properly [in Chrome at least].
EuiIcon
viewBox
All of these are set to size="l" :
size="l"
If I manually modify the bottom two attributes to add viewBox="0 0 16 16":
viewBox="0 0 16 16"
Taking a look at the saved svg files, I noticed that they are either saved with or without viewBox attributes.
svg
Current assets: https://github.com/elastic/eui/tree/df16536/src/components/icon/assets
The text was updated successfully, but these errors were encountered:
These are the files that do not have a viewBox:
$ find . -name "*.svg" -type f | xargs grep -L "viewBox" ./asterisk.svg ./calendar.svg ./checkInCircleFilled.svg ./exit.svg ./expand.svg ./faceNeutral.svg ./iInCircle.svg ./number.svg ./pause.svg ./play.svg ./popout.svg ./refresh.svg ./scale.svg ./share.svg ./sortLeft.svg ./sortRight.svg ./starPlusFilled.svg ./string.svg ./tableOfContents.svg
Sorry, something went wrong.
No branches or pull requests
Some of the
EuiIcon
icons are missing theviewBox
attribute, which causes them to not render properly [in Chrome at least].All of these are set to
size="l"
:If I manually modify the bottom two attributes to add
viewBox="0 0 16 16"
:Taking a look at the saved
svg
files, I noticed that they are either saved with or withoutviewBox
attributes.Current assets: https://github.com/elastic/eui/tree/df16536/src/components/icon/assets
The text was updated successfully, but these errors were encountered: