Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some EuiIcons missing viewBox attribute #276

Closed
pickypg opened this issue Jan 9, 2018 · 1 comment
Closed

Some EuiIcons missing viewBox attribute #276

pickypg opened this issue Jan 9, 2018 · 1 comment
Labels

Comments

@pickypg
Copy link
Member

pickypg commented Jan 9, 2018

Some of the EuiIcon icons are missing the viewBox attribute, which causes them to not render properly [in Chrome at least].

All of these are set to size="l" :

image

If I manually modify the bottom two attributes to add viewBox="0 0 16 16":

image

Taking a look at the saved svg files, I noticed that they are either saved with or without viewBox attributes.

Current assets: https://github.com/elastic/eui/tree/df16536/src/components/icon/assets

@pickypg pickypg added the bug label Jan 9, 2018
@pickypg
Copy link
Member Author

pickypg commented Jan 9, 2018

These are the files that do not have a viewBox:

$ find . -name "*.svg" -type f | xargs grep -L "viewBox"

./asterisk.svg
./calendar.svg
./checkInCircleFilled.svg
./exit.svg
./expand.svg
./faceNeutral.svg
./iInCircle.svg
./number.svg
./pause.svg
./play.svg
./popout.svg
./refresh.svg
./scale.svg
./share.svg
./sortLeft.svg
./sortRight.svg
./starPlusFilled.svg
./string.svg
./tableOfContents.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant