Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting isLoading in BasicTable causing ComputedColumn to lose state #2612

Closed
mikecote opened this issue Dec 9, 2019 · 3 comments · Fixed by #2754
Closed

Setting isLoading in BasicTable causing ComputedColumn to lose state #2612

mikecote opened this issue Dec 9, 2019 · 3 comments · Fixed by #2754
Assignees

Comments

@mikecote
Copy link

mikecote commented Dec 9, 2019

I'm using a BasicTable with a ComputedColumn that renders a popover for each row. I'm having an issue where the popover closes / loses state after loading the BasicTable with updated data. I'm setting isLoading: true before fetching the data and then setting it back to isLoading: false afterwards. Without doing so, everything works fine.

After talking with @chandlerprall, when isLoading is true, the BasicTable is swapping out the EuiTableBody for LoadingTableBody , but rendering the same rows object. However, React sees the wrapping component as fundamentally different and "necessarily" unmounts & remounts everything.

@snide
Copy link
Contributor

snide commented Dec 19, 2019

Marking this as urgent. It is a request for 7.6.

@bmcconaghy
Copy link
Contributor

Wondering where we are on this?

@chandlerprall
Copy link
Contributor

@bmcconaghy I'll take this on early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants