Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Working with tokens and icons #2400

Closed
ryankeairns opened this issue Oct 3, 2019 · 1 comment
Closed

[Discussion] Working with tokens and icons #2400

ryankeairns opened this issue Oct 3, 2019 · 1 comment
Labels

Comments

@ryankeairns
Copy link
Contributor

It seems like we perhaps ought to be using tokens in instances where field lists are being used. However, that component does not currently support the no-background design we're using in Lens, Discover, and DataGrid.

Icons in the base set can be used by EuiToken although they don't always scale to fit well in this smaller size. We could consider adding an alternative no-background design to EuiToken or handle this in some other fashion (including how we move/duplicate existing icons from base to token and vice-versa).

Originally posted by @ryankeairns in #2398 (comment)

@cchaos
Copy link
Contributor

cchaos commented Mar 18, 2020

#2758 Actually updated the EuiToken props to accept a none type of fill. That should suffice for the cases you mention and is already in use by Discover and Lens. Re-open though, if there's more you need from this component.

@cchaos cchaos closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants